Issue 2410993002: [Merge To M54]:arc: Fix Android App resurrected by sync.

Issue 2410993002: [Merge To M54]:arc: Fix Android App resurrected by sync. (Closed)

Created:
4 years, 2 months ago by lgcheng

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, sync-reviews_chromium.org, Matt Giuca

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

More Reviews

Description

arc: Fix Android App resurrected by sync. This patch makes ReadyForStart + ReenableDatatype to be called only when the type is being disabled/re-enabled for some external to sync condition. StartModels/OnModelLoaded is now used to track ARC AppInstanceReady signal. Also moves re-enable sync data type related code from sync service to sync data type controller. BUG=650483 TBR=xiyuan@chromium.org, pavely@chromium.org Test=Pass exsiting Test. Test1=Manually remove app on Chromebook1 while Chromebook2 is off. When Chromebook2 is on, the app is removed by sync. Test2=Manually remove app on Chromebook1 while Chromebook2 is on but offline. When Chromebook2 is back online, app is removed by sync. Test3=Manually remove app on Chromebook1 while Chromebook1 is offline. When Chromebook1 is back online, app is removed by sync on Chromebook2. Review-Url: https://codereview.chromium.org/2353213002 Cr-Commit-Position: refs/heads/master@{#421876} (cherry picked from commit 077a23cfcc11a665a41e878be2270218a0a0f429) Committed: https://chromium.googlesource.com/chromium/src/+/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -64 lines)			Patch
M	chrome/browser/sync/chrome_sync_client.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/sync_arc_package_helper.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h	View	2 chunks	+14 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc	View	3 chunks	+57 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc	View	4 chunks	+0 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgcheng

Description was changed from ========== Fix Android App resurrected by sync. This patch makes ReadyForStart ...

4 years, 2 months ago (2016-10-11 18:26:34 UTC) #1

Description was changed from

==========
Fix Android App resurrected by sync.

This patch makes ReadyForStart + ReenableDatatype to be called only when the
type is being disabled/re-enabled for some external to sync condition.
StartModels/OnModelLoaded is now used to track ARC AppInstanceReady signal.
Also moves re-enable sync data type related code from sync service to sync data
type controller.

BUG=650483

Test=Pass exsiting Test.
Test1=Manually remove app on Chromebook1 while Chromebook2 is off. When
Chromebook2 is on, the app is removed by sync.
Test2=Manually remove app on Chromebook1 while Chromebook2 is on but offline.
When Chromebook2 is back online, app is removed by sync.
Test3=Manually remove app on Chromebook1 while Chromebook1 is offline. When
Chromebook1 is back online, app is removed by sync on Chromebook2.

Review-Url: https://codereview.chromium.org/2353213002
Cr-Commit-Position: refs/heads/master@{#421876}
(cherry picked from commit 077a23cfcc11a665a41e878be2270218a0a0f429)
==========

to

==========
Fix Android App resurrected by sync.

This patch makes ReadyForStart + ReenableDatatype to be called only when the
type is being disabled/re-enabled for some external to sync condition.
StartModels/OnModelLoaded is now used to track ARC AppInstanceReady signal.
Also moves re-enable sync data type related code from sync service to sync data
type controller.

BUG=650483

TBR=xiyuan@chromium.org, pavely@chromium.org

Test=Pass exsiting Test.
Test1=Manually remove app on Chromebook1 while Chromebook2 is off. When
Chromebook2 is on, the app is removed by sync.
Test2=Manually remove app on Chromebook1 while Chromebook2 is on but offline.
When Chromebook2 is back online, app is removed by sync.
Test3=Manually remove app on Chromebook1 while Chromebook1 is offline. When
Chromebook1 is back online, app is removed by sync on Chromebook2.

Review-Url: https://codereview.chromium.org/2353213002
Cr-Commit-Position: refs/heads/master@{#421876}
(cherry picked from commit 077a23cfcc11a665a41e878be2270218a0a0f429)
==========

lgcheng

Description was changed from ========== Fix Android App resurrected by sync. This patch makes ReadyForStart ...

4 years, 2 months ago (2016-10-11 22:15:32 UTC) #2

Description was changed from

==========
Fix Android App resurrected by sync.

This patch makes ReadyForStart + ReenableDatatype to be called only when the
type is being disabled/re-enabled for some external to sync condition.
StartModels/OnModelLoaded is now used to track ARC AppInstanceReady signal.
Also moves re-enable sync data type related code from sync service to sync data
type controller.

BUG=650483

TBR=xiyuan@chromium.org, pavely@chromium.org

Test=Pass exsiting Test.
Test1=Manually remove app on Chromebook1 while Chromebook2 is off. When
Chromebook2 is on, the app is removed by sync.
Test2=Manually remove app on Chromebook1 while Chromebook2 is on but offline.
When Chromebook2 is back online, app is removed by sync.
Test3=Manually remove app on Chromebook1 while Chromebook1 is offline. When
Chromebook1 is back online, app is removed by sync on Chromebook2.

Review-Url: https://codereview.chromium.org/2353213002
Cr-Commit-Position: refs/heads/master@{#421876}
(cherry picked from commit 077a23cfcc11a665a41e878be2270218a0a0f429)
==========

to

==========
arc: Fix Android App resurrected by sync.

This patch makes ReadyForStart + ReenableDatatype to be called only when the
type is being disabled/re-enabled for some external to sync condition.
StartModels/OnModelLoaded is now used to track ARC AppInstanceReady signal.
Also moves re-enable sync data type related code from sync service to sync data
type controller.

BUG=650483

TBR=xiyuan@chromium.org, pavely@chromium.org

Test=Pass exsiting Test.
Test1=Manually remove app on Chromebook1 while Chromebook2 is off. When
Chromebook2 is on, the app is removed by sync.
Test2=Manually remove app on Chromebook1 while Chromebook2 is on but offline.
When Chromebook2 is back online, app is removed by sync.
Test3=Manually remove app on Chromebook1 while Chromebook1 is offline. When
Chromebook1 is back online, app is removed by sync on Chromebook2.

Review-Url: https://codereview.chromium.org/2353213002
Cr-Commit-Position: refs/heads/master@{#421876}
(cherry picked from commit 077a23cfcc11a665a41e878be2270218a0a0f429)
==========

Josh Horwich

Description was changed from ========== arc: Fix Android App resurrected by sync. This patch makes ...

4 years, 2 months ago (2016-10-11 23:10:05 UTC) #3

Description was changed from

==========
arc: Fix Android App resurrected by sync.

This patch makes ReadyForStart + ReenableDatatype to be called only when the
type is being disabled/re-enabled for some external to sync condition.
StartModels/OnModelLoaded is now used to track ARC AppInstanceReady signal.
Also moves re-enable sync data type related code from sync service to sync data
type controller.

BUG=650483

TBR=xiyuan@chromium.org, pavely@chromium.org

Test=Pass exsiting Test.
Test1=Manually remove app on Chromebook1 while Chromebook2 is off. When
Chromebook2 is on, the app is removed by sync.
Test2=Manually remove app on Chromebook1 while Chromebook2 is on but offline.
When Chromebook2 is back online, app is removed by sync.
Test3=Manually remove app on Chromebook1 while Chromebook1 is offline. When
Chromebook1 is back online, app is removed by sync on Chromebook2.

Review-Url: https://codereview.chromium.org/2353213002
Cr-Commit-Position: refs/heads/master@{#421876}
(cherry picked from commit 077a23cfcc11a665a41e878be2270218a0a0f429)
==========

to

==========
arc: Fix Android App resurrected by sync.

This patch makes ReadyForStart + ReenableDatatype to be called only when the
type is being disabled/re-enabled for some external to sync condition.
StartModels/OnModelLoaded is now used to track ARC AppInstanceReady signal.
Also moves re-enable sync data type related code from sync service to sync data
type controller.

BUG=650483

TBR=xiyuan@chromium.org, pavely@chromium.org

Test=Pass exsiting Test.
Test1=Manually remove app on Chromebook1 while Chromebook2 is off. When
Chromebook2 is on, the app is removed by sync.
Test2=Manually remove app on Chromebook1 while Chromebook2 is on but offline.
When Chromebook2 is back online, app is removed by sync.
Test3=Manually remove app on Chromebook1 while Chromebook1 is offline. When
Chromebook1 is back online, app is removed by sync on Chromebook2.

Review-Url: https://codereview.chromium.org/2353213002
Cr-Commit-Position: refs/heads/master@{#421876}
(cherry picked from commit 077a23cfcc11a665a41e878be2270218a0a0f429)

Committed:
https://chromium.googlesource.com/chromium/src/+/276127c923c28cafe3e4fddd1ab8...
==========

Josh Horwich

4 years, 2 months ago (2016-10-11 23:10:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages