Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2410973002: Move enable_remoting build flag to remoting dir. (Closed)

Created:
4 years, 2 months ago by brettw
Modified:
4 years, 2 months ago
Reviewers:
Wez, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move enable_remoting build flag to remoting dir. There is already a remoting_enable.gni file in the remoting directory. This flag should be contained in there rather than in the global feature flags file. Committed: https://crrev.com/2b112cd25fcc75ec6d764a789acebfa60022780d Cr-Commit-Position: refs/heads/master@{#424824}

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/config/features.gni View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_enable.gni View 1 chunk +4 lines, -2 lines 0 comments Download
M remoting/webapp/build_template.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
brettw
4 years, 2 months ago (2016-10-11 17:57:01 UTC) #2
brettw
Merge
4 years, 2 months ago (2016-10-11 18:00:39 UTC) #7
Jamie
lgtm
4 years, 2 months ago (2016-10-12 00:58:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410973002/20001
4 years, 2 months ago (2016-10-12 03:05:42 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/85237)
4 years, 2 months ago (2016-10-12 03:09:37 UTC) #21
brettw
Merge
4 years, 2 months ago (2016-10-12 18:28:57 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410973002/40001
4 years, 2 months ago (2016-10-12 18:29:47 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-12 19:36:01 UTC) #26
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 19:37:48 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2b112cd25fcc75ec6d764a789acebfa60022780d
Cr-Commit-Position: refs/heads/master@{#424824}

Powered by Google App Engine
This is Rietveld 408576698