[wasm] Fix decoding of shared global index space

Imported and defined globals share an index space, but previously the decoder clobbered the imported global indices with the defined globals.

BUG=none

Committed: https://crrev.com/9b55c0769857d15c722f5d599bdc1c5828bfed99
Cr-Commit-Position: refs/heads/master@{#40230}

[Derek Schuff, 2016-10-12 00:58:32]

Description was changed from

==========
Just the code

BUG=
==========

to

==========
Imported and defined globals share an index space, but previously the decoder
clobbered the imported global indices with the defined globals.

BUG=none
==========

[Derek Schuff, 2016-10-12 00:58:32]

dschuff@chromium.org changed reviewers:
+ bradnelson@chromium.org, titzer@chromium.org

[titzer, 2016-10-12 04:56:29]

lgtm with nit

https://codereview.chromium.org/2410953003/diff/20001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2410953003/diff/20001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:1549: // TODO: These should be runtime errors and not
CHECKs if dest_addr
You can make these TODO(titzer)

[Derek Schuff, 2016-10-12 05:09:25]

https://codereview.chromium.org/2410953003/diff/20001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2410953003/diff/20001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:1549: // TODO: These should be runtime errors and not
CHECKs if dest_addr
On 2016/10/12 04:56:29, titzer wrote:
> You can make these TODO(titzer)

Done.

[Derek Schuff, 2016-10-12 05:09:34]

The CQ bit was checked by dschuff@chromium.org

[Derek Schuff, 2016-10-12 05:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2410953003/#ps40001
(title: "review comment")

[commit-bot: I haz the power, 2016-10-12 05:09:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 05:24:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 05:24:09]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Derek Schuff, 2016-10-12 05:35:20]

https://codereview.chromium.org/2410953003/diff/40001/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2410953003/diff/40001/src/wasm/module-decoder...
src/wasm/module-decoder.cc:401: if (!IsWithinLimit(kMaxReserve, globals_count,
imported_globals)) {
OK, so I was afraid this would be a problem; I was trying to worry about the sum
of the imported + defined globals overflowing some nebulous limit, but obviously
kMaxReserve is too small (it's causing the test failure). So, any suggestions?
INT_MAX? Just cast to int64 and do UINT_MAX? Something in between?

[Derek Schuff, 2016-10-12 05:43:05]

The CQ bit was checked by dschuff@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 05:43:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Derek Schuff, 2016-10-12 05:46:30]

On 2016/10/12 05:35:20, Derek Schuff wrote:
>
https://codereview.chromium.org/2410953003/diff/40001/src/wasm/module-decoder.cc
> File src/wasm/module-decoder.cc (right):
> 
>
https://codereview.chromium.org/2410953003/diff/40001/src/wasm/module-decoder...
> src/wasm/module-decoder.cc:401: if (!IsWithinLimit(kMaxReserve, globals_count,
> imported_globals)) {
> OK, so I was afraid this would be a problem; I was trying to worry about the
sum
> of the imported + defined globals overflowing some nebulous limit, but
obviously
> kMaxReserve is too small (it's causing the test failure). So, any suggestions?
> INT_MAX? Just cast to int64 and do UINT_MAX? Something in between?

went with INT_MAX for now. That's probably too large to be useful as an anti-OOM
heuristic like SafeReserve but maybe will at least keep from nasty overflow or
security bugs.

[commit-bot: I haz the power, 2016-10-12 06:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 06:33:58]

Dry run: Try jobs failed on following builders:
  v8_linux64_sanitizer_coverage_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_sanitizer_covera...)

[Derek Schuff, 2016-10-12 06:42:33]

The CQ bit was checked by dschuff@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 06:42:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 07:31:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 07:31:47]

Dry run: This issue passed the CQ dry run.

[Derek Schuff, 2016-10-12 15:17:20]

The CQ bit was checked by dschuff@chromium.org

[Derek Schuff, 2016-10-12 15:17:21]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2410953003/#ps60001
(title: "Increase allocation limit")

[commit-bot: I haz the power, 2016-10-12 15:17:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:19:27]

Description was changed from

==========
Imported and defined globals share an index space, but previously the decoder
clobbered the imported global indices with the defined globals.

BUG=none
==========

to

==========
Imported and defined globals share an index space, but previously the decoder
clobbered the imported global indices with the defined globals.

BUG=none
==========

[commit-bot: I haz the power, 2016-10-12 15:19:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-12 15:19:49]

Description was changed from

==========
Imported and defined globals share an index space, but previously the decoder
clobbered the imported global indices with the defined globals.

BUG=none
==========

to

==========
Imported and defined globals share an index space, but previously the decoder
clobbered the imported global indices with the defined globals.

BUG=none

Committed: https://crrev.com/9b55c0769857d15c722f5d599bdc1c5828bfed99
Cr-Commit-Position: refs/heads/master@{#40230}
==========

[commit-bot: I haz the power, 2016-10-12 15:19:50]

Patchset 4 (id:??) landed as
https://crrev.com/9b55c0769857d15c722f5d599bdc1c5828bfed99
Cr-Commit-Position: refs/heads/master@{#40230}