Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2410943004: Revert of Enabling enable_vr_shell flag and tests on chromium.android (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enabling enable_vr_shell flag and tests on chromium.android (patchset #2 id:20001 of https://codereview.chromium.org/2407363002/ ) Reason for revert: Android arm64 Builder started failing: https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/9475 Nothing super obvious in that list of changes, but this specifically calls out chromium.android. Original issue's description: > Enabling enable_vr_shell flag and tests on chromium.android > > This enables the "enable_vr_shell" build flag that has been used on > chromium.fyi's "Android Builder (dbg)" builder without issue for some time. > https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29 > > This also enables the vr_shell_unittests tests that have been running on > chromium.fyi's "Android VR Tests" builder for a couple weeks. > https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests > > Original CL to add the tests: https://codereview.chromium.org/2356983002/ > > BUG= > > Committed: https://crrev.com/23c165a3f056bd427662e794e39b86f35c5fc255 > Cr-Commit-Position: refs/heads/master@{#424757} TBR=jam@chromium.org,stip@chromium.org,bsheedy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d62b0ef3d51e6c96e3bb960c1a4fa395082dccf9 Cr-Commit-Position: refs/heads/master@{#424780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -54 lines) Patch
M testing/buildbot/chromium.android.json View 8 chunks +0 lines, -52 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ted C
Created Revert of Enabling enable_vr_shell flag and tests on chromium.android
4 years, 2 months ago (2016-10-12 17:34:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410943004/1
4 years, 2 months ago (2016-10-12 17:34:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 17:36:18 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 17:49:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d62b0ef3d51e6c96e3bb960c1a4fa395082dccf9
Cr-Commit-Position: refs/heads/master@{#424780}

Powered by Google App Engine
This is Rietveld 408576698