Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: test/inspector/runtime/protocol-works-with-different-locale.js

Issue 2410933002: [inspector] fix timestamp formatting with non C locales (Closed)
Patch Set: using stringstream Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/inspector/runtime/protocol-works-with-different-locale.js
diff --git a/test/inspector/runtime/protocol-works-with-different-locale.js b/test/inspector/runtime/protocol-works-with-different-locale.js
new file mode 100644
index 0000000000000000000000000000000000000000..530d0dfbe0ed7ab8f59fbfcf5ca2b91038cfe01d
--- /dev/null
+++ b/test/inspector/runtime/protocol-works-with-different-locale.js
@@ -0,0 +1,41 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+Protocol.Runtime.enable();
+
+Protocol.Runtime.onConsoleAPICalled(dumpConsoleApiCalled);
+
+InspectorTest.runTestSuite([
+ function consoleLogWithDefaultLocale(next) {
+ Protocol.Runtime.evaluate({ expression: "console.log(239) "}).then(next);
+ },
+
+ function consoleTimeWithCommaAsSeparator(next) {
+ InspectorTest.log("set locale to fr_CA.UTF-8 (has comma as separator)");
+ setlocale("fr_CA.UTF-8");
+ Protocol.Runtime.evaluate({ expression: "console.time(\"a\"); console.timeEnd(\"a\")"}).then(next);
+ },
+
+ function consoleLogWithCommaAsSeparator(next) {
+ InspectorTest.log("set locale to fr_CA.UTF-8 (has comma as separator)");
+ setlocale("fr_CA.UTF-8");
+ Protocol.Runtime.evaluate({ expression: "console.log(239) "}).then(next);
+ },
+
+ function consoleTimeWithCommaAfterConsoleLog(next) {
+ InspectorTest.log("set locale to fr_CA.UTF-8 (has comma as separator)");
+ setlocale("fr_CA.UTF-8");
+ Protocol.Runtime.evaluate({ expression: "console.log(239) "})
+ .then(() => Protocol.Runtime.evaluate({ expression: "console.time(\"a\"); console.timeEnd(\"a\")"}))
+ .then(next);
+ }
+]);
+
+function dumpConsoleApiCalled(message)
+{
dgozman 2016/10/11 21:03:35 { on next line
kozy 2016/10/11 22:26:15 Done.
+ var firstArg = message.params.args[0];
+ if (firstArg.type === "string")
+ firstArg.value = firstArg.value.replace(/[0-9]+/g, "x");
+ InspectorTest.logMessage(message);
+}

Powered by Google App Engine
This is Rietveld 408576698