[inspector] fix timestamp formatting with non C locales

src/inspector/string-16.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/string-16.h"
 
 #include <algorithm>
 #include <cctype>
 #include <cstdlib>
 #include <cstring>
@@ skipping 362 matching lines @@
 
 // static
 String16 String16::fromInteger(size_t number) {
   const size_t kBufferSize = 50;
   char buffer[kBufferSize];
   v8::base::OS::SNPrintF(buffer, kBufferSize, "%zu", number);
   return String16(buffer);
 }
 
 // static
 String16 String16::fromDouble(double number) {

[dgozman, 2016/10/11 19:35:07]

I don't think we ever want this method, so leave one.

[kozy, 2016/10/11 20:55:52]

Done.

   const size_t kBufferSize = 100;
   char buffer[kBufferSize];
   v8::base::OS::SNPrintF(buffer, kBufferSize, "%f", number);
   return String16(buffer);
 }
 
 // static
+String16 String16::fromDoubleForcePointAsSeparator(double number) {
+  const size_t kBufferSize = 100;
+  char buffer[kBufferSize];
+  std::string prev_locale = setlocale(LC_NUMERIC, NULL);
+  setlocale(LC_NUMERIC, "C");
+  v8::base::OS::SNPrintF(buffer, kBufferSize, "%f", number);
+  setlocale(LC_NUMERIC, prev_locale.c_str());
+  return String16(buffer);
+}
+
+// static
 String16 String16::fromDoublePrecision3(double number) {
   const size_t kBufferSize = 100;
   char buffer[kBufferSize];
   v8::base::OS::SNPrintF(buffer, kBufferSize, "%.3g", number);
   return String16(buffer);
 }
 
 // static
 String16 String16::fromDoublePrecision6(double number) {
   const size_t kBufferSize = 100;
@@ skipping 113 matching lines @@
     // There should be room left, since one UChar hasn't been
     // converted.
     DCHECK((buffer + 3) <= (buffer + bufferVector.size()));
     putUTF8Triple(buffer, *characters);
   }
 
   return std::string(bufferVector.data(), buffer - bufferVector.data());
 }
 
 }  // namespace v8_inspector