[inspector] fix timestamp formatting with non C locales

[inspector] fix timestamp formatting with non C locales

If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted.

BUG=chromium:653424
R=dgozman@chromium.org

Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4
Committed: https://crrev.com/7ba222ffcb4c330959f3ebb69ab52a4fd2a3646b
Cr-Original-Commit-Position: refs/heads/master@{#40190}
Cr-Commit-Position: refs/heads/master@{#40288}

[kozy, 2016-10-11 17:12:16]

Dmitry, please take a look.

[dgozman, 2016-10-11 19:35:07]

https://codereview.chromium.org/2410933002/diff/20001/src/inspector/string-16.cc
File src/inspector/string-16.cc (right):

https://codereview.chromium.org/2410933002/diff/20001/src/inspector/string-16...
src/inspector/string-16.cc:383: String16 String16::fromDouble(double number) {
I don't think we ever want this method, so leave one.

https://codereview.chromium.org/2410933002/diff/20001/test/inspector/runtime/...
File test/inspector/runtime/protocol-works-with-different-locale.js (right):

https://codereview.chromium.org/2410933002/diff/20001/test/inspector/runtime/...
test/inspector/runtime/protocol-works-with-different-locale.js:10: function
consoleLogWithDefaultLocale(next)
{ on the same line

[kozy, 2016-10-11 20:55:52]

All done. Please take a look.

After small research I found that all printf* like functions use current locale
for decimal separator. Chromium uses separate library for string -> double
conversion. std::stringstream looks like simplest solution here.

https://codereview.chromium.org/2410933002/diff/20001/src/inspector/string-16.cc
File src/inspector/string-16.cc (right):

https://codereview.chromium.org/2410933002/diff/20001/src/inspector/string-16...
src/inspector/string-16.cc:383: String16 String16::fromDouble(double number) {
On 2016/10/11 19:35:07, dgozman wrote:
> I don't think we ever want this method, so leave one.

Done.

https://codereview.chromium.org/2410933002/diff/20001/test/inspector/runtime/...
File test/inspector/runtime/protocol-works-with-different-locale.js (right):

https://codereview.chromium.org/2410933002/diff/20001/test/inspector/runtime/...
test/inspector/runtime/protocol-works-with-different-locale.js:10: function
consoleLogWithDefaultLocale(next)
On 2016/10/11 19:35:07, dgozman wrote:
> { on the same line

Done.

[dgozman, 2016-10-11 21:03:35]

lgtm

https://codereview.chromium.org/2410933002/diff/40001/src/inspector/string-16.cc
File src/inspector/string-16.cc (right):

https://codereview.chromium.org/2410933002/diff/40001/src/inspector/string-16...
src/inspector/string-16.cc:402: String16 String16::fromDoublePrecision6(double
number) {
Let's combine with previous one.

https://codereview.chromium.org/2410933002/diff/40001/src/inspector/string-16.h
File src/inspector/string-16.h (right):

https://codereview.chromium.org/2410933002/diff/40001/src/inspector/string-16...
src/inspector/string-16.h:38: static String16
fromDoubleForcePointAsSeparator(double);
Remove.

https://codereview.chromium.org/2410933002/diff/40001/test/inspector/runtime/...
File test/inspector/runtime/protocol-works-with-different-locale.js (right):

https://codereview.chromium.org/2410933002/diff/40001/test/inspector/runtime/...
test/inspector/runtime/protocol-works-with-different-locale.js:36: {
{ on next line

[kozy, 2016-10-11 21:12:44]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 21:12:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 21:19:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 21:19:17]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[kozy, 2016-10-11 21:21:30]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 21:21:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 21:47:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 21:47:16]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-10-11 22:25:50]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-10-11 22:25:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2410933002/#ps120001
(title: "a")

[commit-bot: I haz the power, 2016-10-11 22:26:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-10-11 22:26:15]

all done!

https://codereview.chromium.org/2410933002/diff/40001/src/inspector/string-16.cc
File src/inspector/string-16.cc (right):

https://codereview.chromium.org/2410933002/diff/40001/src/inspector/string-16...
src/inspector/string-16.cc:402: String16 String16::fromDoublePrecision6(double
number) {
On 2016/10/11 21:03:35, dgozman wrote:
> Let's combine with previous one.

Done.

https://codereview.chromium.org/2410933002/diff/40001/src/inspector/string-16.h
File src/inspector/string-16.h (right):

https://codereview.chromium.org/2410933002/diff/40001/src/inspector/string-16...
src/inspector/string-16.h:38: static String16
fromDoubleForcePointAsSeparator(double);
On 2016/10/11 21:03:35, dgozman wrote:
> Remove.

Done.

https://codereview.chromium.org/2410933002/diff/40001/test/inspector/runtime/...
File test/inspector/runtime/protocol-works-with-different-locale.js (right):

https://codereview.chromium.org/2410933002/diff/40001/test/inspector/runtime/...
test/inspector/runtime/protocol-works-with-different-locale.js:36: {
On 2016/10/11 21:03:35, dgozman wrote:
> { on next line

Done.

[commit-bot: I haz the power, 2016-10-11 23:21:59]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-11 23:22:17]

Description was changed from

==========
[inspector] fix timestamp formatting with non C locales

If current locale has "," as decimal separator then message for consoleAPICalled
will be corrupted.

BUG=chromium:653424
R=dgozman@chromium.org
==========

to

==========
[inspector] fix timestamp formatting with non C locales

If current locale has "," as decimal separator then message for consoleAPICalled
will be corrupted.

BUG=chromium:653424
R=dgozman@chromium.org

Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4
Cr-Commit-Position: refs/heads/master@{#40190}
==========

[commit-bot: I haz the power, 2016-10-11 23:22:18]

Patchset 7 (id:??) landed as
https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4
Cr-Commit-Position: refs/heads/master@{#40190}

[Michael Achenbach, 2016-10-12 08:18:09]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2419453002/ by machenbach@chromium.org.

The reason for reverting is: Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

See also:
https://github.com/v8/v8/wiki/Blink-layout-tests.

[kozy, 2016-10-13 16:54:47]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 16:54:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-10-13 16:55:14]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-10-13 17:44:17]

Patchset #8 (id:140001) has been deleted

[kozy, 2016-10-13 20:02:31]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-10-13 20:02:32]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2410933002/#ps120001
(title: "a")

[commit-bot: I haz the power, 2016-10-13 20:02:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-10-13 20:03:14]

Tests were marked as needed rebaseline, v8_blink bot passed successfully.

[commit-bot: I haz the power, 2016-10-13 20:31:37]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-13 20:32:14]

Description was changed from

==========
[inspector] fix timestamp formatting with non C locales

If current locale has "," as decimal separator then message for consoleAPICalled
will be corrupted.

BUG=chromium:653424
R=dgozman@chromium.org

Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4
Cr-Commit-Position: refs/heads/master@{#40190}
==========

to

==========
[inspector] fix timestamp formatting with non C locales

If current locale has "," as decimal separator then message for consoleAPICalled
will be corrupted.

BUG=chromium:653424
R=dgozman@chromium.org

Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4
Committed: https://crrev.com/7ba222ffcb4c330959f3ebb69ab52a4fd2a3646b
Cr-Original-Commit-Position: refs/heads/master@{#40190}
Cr-Commit-Position: refs/heads/master@{#40288}
==========

[commit-bot: I haz the power, 2016-10-13 20:32:16]

Patchset 7 (id:??) landed as
https://crrev.com/7ba222ffcb4c330959f3ebb69ab52a4fd2a3646b
Cr-Commit-Position: refs/heads/master@{#40288}