Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2410913002: [wasm] Fix decoder for null data (Closed)

Created:
4 years, 2 months ago by Clemens Hammacher
Modified:
4 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix decoder for null data If passing <nullptr, 0> to the decoder and trying to decode something, it correctly detects the error and sets an error message, but still returns true on ok(), and returns a valid result. I triggered this error by passing a null Vector, returned by FindSection(), to the decoder. R=titzer@chromium.org Committed: https://crrev.com/e7a00891495d123f68b7fe0f2a43839e34591c8e Cr-Commit-Position: refs/heads/master@{#40204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/wasm/decoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/wasm/decoder-unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Clemens Hammacher
4 years, 2 months ago (2016-10-11 16:06:46 UTC) #5
titzer
lgtm
4 years, 2 months ago (2016-10-12 09:09:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410913002/1
4 years, 2 months ago (2016-10-12 09:09:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 09:11:47 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 09:12:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7a00891495d123f68b7fe0f2a43839e34591c8e
Cr-Commit-Position: refs/heads/master@{#40204}

Powered by Google App Engine
This is Rietveld 408576698