Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: components/offline_pages/background/request_queue_store.h

Issue 2410903003: [Offline pages] Adding capability to query a subset of requests based on IDs (Closed)
Patch Set: Addressing remaining feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_store.h
diff --git a/components/offline_pages/background/request_queue_store.h b/components/offline_pages/background/request_queue_store.h
index b661ea0faae1341c06c30b99d709ba70acb44138..bb2e5966e2330f57404b93dcb00ea9205e14f958 100644
--- a/components/offline_pages/background/request_queue_store.h
+++ b/components/offline_pages/background/request_queue_store.h
@@ -38,6 +38,11 @@ class RequestQueueStore {
// Gets all of the requests from the store.
virtual void GetRequests(const GetRequestsCallback& callback) = 0;
+ // Gets requests with specified IDs from the store. UpdateCallback is used
+ // instead of GetRequestsCallback to indicate which requests where not found.
+ virtual void GetRequestsByIds(const std::vector<int64_t>& request_ids,
+ const UpdateCallback& callback) = 0;
+
// Asynchronously adds request in store. Fails if request with the same
// offline ID already exists.
virtual void AddRequest(const SavePageRequest& offline_page,

Powered by Google App Engine
This is Rietveld 408576698