Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: components/offline_pages/background/request_queue_in_memory_store.cc

Issue 2410903003: [Offline pages] Adding capability to query a subset of requests based on IDs (Closed)
Patch Set: Addressing remaining feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_queue_in_memory_store.h" 5 #include "components/offline_pages/background/request_queue_in_memory_store.h"
6 6
7 #include <unordered_set>
8
7 #include "base/bind.h" 9 #include "base/bind.h"
8 #include "base/location.h" 10 #include "base/location.h"
9 #include "base/threading/thread_task_runner_handle.h" 11 #include "base/threading/thread_task_runner_handle.h"
10 #include "components/offline_pages/background/save_page_request.h" 12 #include "components/offline_pages/background/save_page_request.h"
11 13
12 namespace offline_pages { 14 namespace offline_pages {
13 15
14 RequestQueueInMemoryStore::RequestQueueInMemoryStore() {} 16 RequestQueueInMemoryStore::RequestQueueInMemoryStore() {}
15 17
16 RequestQueueInMemoryStore::~RequestQueueInMemoryStore() {} 18 RequestQueueInMemoryStore::~RequestQueueInMemoryStore() {}
17 19
18 void RequestQueueInMemoryStore::GetRequests( 20 void RequestQueueInMemoryStore::GetRequests(
19 const GetRequestsCallback& callback) { 21 const GetRequestsCallback& callback) {
20 std::vector<std::unique_ptr<SavePageRequest>> result_requests; 22 std::vector<std::unique_ptr<SavePageRequest>> result_requests;
21 for (const auto& id_request_pair : requests_) { 23 for (const auto& id_request_pair : requests_) {
22 std::unique_ptr<SavePageRequest> request( 24 std::unique_ptr<SavePageRequest> request(
23 new SavePageRequest(id_request_pair.second)); 25 new SavePageRequest(id_request_pair.second));
24 result_requests.push_back(std::move(request)); 26 result_requests.push_back(std::move(request));
25 } 27 }
26 base::ThreadTaskRunnerHandle::Get()->PostTask( 28 base::ThreadTaskRunnerHandle::Get()->PostTask(
27 FROM_HERE, 29 FROM_HERE,
28 base::Bind(callback, true, base::Passed(std::move(result_requests)))); 30 base::Bind(callback, true, base::Passed(std::move(result_requests))));
29 } 31 }
30 32
33 void RequestQueueInMemoryStore::GetRequestsByIds(
34 const std::vector<int64_t>& request_ids,
35 const UpdateCallback& callback) {
36 std::unique_ptr<UpdateRequestsResult> result(
37 new UpdateRequestsResult(state()));
38
39 ItemActionStatus status;
40 // Make sure not to include the same request multiple times, while preserving
41 // the order of non-duplicated IDs in the result.
42 std::unordered_set<int64_t> processed_ids;
43 for (const auto& request_id : request_ids) {
44 if (!processed_ids.insert(request_id).second)
45 continue;
46 RequestsMap::iterator iter = requests_.find(request_id);
47 if (iter != requests_.end()) {
48 status = ItemActionStatus::SUCCESS;
49 result->updated_items.push_back(iter->second);
50 } else {
51 status = ItemActionStatus::NOT_FOUND;
52 }
53 result->item_statuses.push_back(std::make_pair(request_id, status));
54 }
55
56 base::ThreadTaskRunnerHandle::Get()->PostTask(
57 FROM_HERE, base::Bind(callback, base::Passed(&result)));
58 }
59
31 void RequestQueueInMemoryStore::AddRequest(const SavePageRequest& request, 60 void RequestQueueInMemoryStore::AddRequest(const SavePageRequest& request,
32 const AddCallback& callback) { 61 const AddCallback& callback) {
33 RequestsMap::iterator iter = requests_.find(request.request_id()); 62 RequestsMap::iterator iter = requests_.find(request.request_id());
34 ItemActionStatus status; 63 ItemActionStatus status;
35 if (iter == requests_.end()) { 64 if (iter == requests_.end()) {
36 requests_.insert(iter, std::make_pair(request.request_id(), request)); 65 requests_.insert(iter, std::make_pair(request.request_id(), request));
37 status = ItemActionStatus::SUCCESS; 66 status = ItemActionStatus::SUCCESS;
38 } else { 67 } else {
39 status = ItemActionStatus::ALREADY_EXISTS; 68 status = ItemActionStatus::ALREADY_EXISTS;
40 } 69 }
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 requests_.clear(); 125 requests_.clear();
97 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, 126 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
98 base::Bind(callback, true)); 127 base::Bind(callback, true));
99 } 128 }
100 129
101 StoreState RequestQueueInMemoryStore::state() const { 130 StoreState RequestQueueInMemoryStore::state() const {
102 return StoreState::LOADED; 131 return StoreState::LOADED;
103 } 132 }
104 133
105 } // namespace offline_pages 134 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698