Switching to a new format for sending errors

chrome/browser/resources/google_now/utility.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview Utility objects and functions for Google Now extension.
  * Most important entities here:
  * (1) 'wrapper' is a module used to add error handling and other services to
@@ skipping 100 matching lines @@
     if (topFrameElements.length >= 3) {
       file = topFrameElements[topFrameElements.length - 3];
       line = topFrameElements[topFrameElements.length - 2];
     }
   }
 
   var errorText = error.name;
   if (error.canSendMessageToServer)
     errorText = errorText + ': ' + error.message;
 
-  var requestParameters =
-      'error=' + encodeURIComponent(errorText) +
-      '&script=' + encodeURIComponent(file) +

[robliao, 2013/09/24 20:14:43]

Don't the unit tests need to update for this change?

[vadimt, 2013/09/24 21:10:50]

Ah, you are right!
Done.

-      '&line=' + encodeURIComponent(line) +
-      '&trace=' + encodeURIComponent(filteredStack);
-  var request = buildServerRequest('jserror',
-                                   'application/x-www-form-urlencoded');
+  var errorObject = {
+    message: errorText,
+    file: file,
+    line: line,
+    trace: filteredStack
+  };
+
+  var request = buildServerRequest('jserrors', 'application/json');
   request.onloadend = function(event) {
     console.log('sendErrorReport status: ' + request.status);
   };
-  request.send(requestParameters);
+  request.send(JSON.stringify(errorObject));
 }
 
 // Limiting 1 error report per background page load.
 var errorReported = false;
 
 /**
  * Reports an error to the server and the user, as appropriate.
  * @param {Error} error Error to report.
  */
 function reportError(error) {
@@ skipping 589 matching lines @@
   // Poll for the sign in state every hour.
   // One hour is just an arbitrary amount of time chosen.
   chrome.alarms.create(alarmName, {periodInMinutes: 60});
 
   return {
     addListener: addListener,
     isSignedIn: isSignedIn,
     removeToken: removeToken
   };
 }