Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24109007: Switching to a new format for sending errors (Closed)

Created:
7 years, 2 months ago by vadimt
Modified:
7 years, 2 months ago
Reviewers:
robliao, rgustafson, skare_
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Switching to a new format for sending errors. BUG=164227 TEST=No Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227735

Patch Set 1 #

Total comments: 2

Patch Set 2 : robliao@ comments #

Patch Set 3 : Retry upload #

Patch Set 4 : AUTO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -32 lines) Patch
M chrome/browser/resources/google_now/utility.js View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/resources/google_now/utility_unittest.gtestjs View 1 2 3 2 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
vadimt
7 years, 2 months ago (2013-09-24 20:05:40 UTC) #1
robliao
https://codereview.chromium.org/24109007/diff/1/chrome/browser/resources/google_now/utility.js File chrome/browser/resources/google_now/utility.js (left): https://codereview.chromium.org/24109007/diff/1/chrome/browser/resources/google_now/utility.js#oldcode123 chrome/browser/resources/google_now/utility.js:123: '&script=' + encodeURIComponent(file) + Don't the unit tests need ...
7 years, 2 months ago (2013-09-24 20:14:43 UTC) #2
vadimt
https://codereview.chromium.org/24109007/diff/1/chrome/browser/resources/google_now/utility.js File chrome/browser/resources/google_now/utility.js (left): https://codereview.chromium.org/24109007/diff/1/chrome/browser/resources/google_now/utility.js#oldcode123 chrome/browser/resources/google_now/utility.js:123: '&script=' + encodeURIComponent(file) + On 2013/09/24 20:14:43, Robert Liao ...
7 years, 2 months ago (2013-09-24 21:10:49 UTC) #3
robliao
lgtm
7 years, 2 months ago (2013-09-24 21:17:31 UTC) #4
rgustafson
lgtm
7 years, 2 months ago (2013-09-24 22:17:11 UTC) #5
vadimt
AUTO
7 years, 2 months ago (2013-09-25 17:47:58 UTC) #6
skare_
lgtm
7 years, 2 months ago (2013-09-25 23:05:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/24109007/23001
7 years, 2 months ago (2013-10-08 22:08:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/24109007/23001
7 years, 2 months ago (2013-10-09 02:07:24 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-09 03:53:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/24109007/23001
7 years, 2 months ago (2013-10-09 13:47:25 UTC) #11
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 13:58:11 UTC) #12
Message was sent while issue was closed. 
Change committed as 227735

Powered by Google App Engine
This is Rietveld 408576698