[DevTools] Resources panel SideBarTreeElement should show expand/collapse option only if it has chi…

[DevTools] Resources panel SideBarTreeElement should show expand/collapse option only if it has children

Currently Resources panel sidebar tree elements show expand/collapse option irrespective of
them having children or not. This could be misunderstood as an error in inspector.

This change fixes the same by providing expand/collapse option only when the tree elements
have children.

R=pfeldman

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157951

[pfeldman, 2013-09-12 11:25:32]

lgtm

[commit-bot: I haz the power, 2013-09-12 11:36:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/24109003/1

[commit-bot: I haz the power, 2013-09-12 13:02:23]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[vanihegde, 2013-09-16 11:18:23]

Hi,

LayoutTests/http/tests/inspector/indexeddb/resources-panel.html is timing out
with this change.
Since hasChildern is set to false, IndexedDBTreeElement::onexpand() is not
invoked from TreeElement::expand() and hence IndexedDBModel is not created.

To fix this, I moved the below code
    if (!this._indexedDBModel)
        this._createIndexedDBModel();
to IndexedDBTreeElement constructor (which was previously done in
IndexedDBTreeElement::onexpand).

This fixes the time out issue, but the test still fails as few logs are not
added as per expected file

Ex:
    InspectorTest.addSniffer(WebInspector.IndexedDBTreeElement.prototype,
"_indexedDBRemoved", indexedDBRemoved, true);
    function indexedDBRemoved()
    {
        InspectorTest.addResult("Database removed.");
    }

When the test is executed the control never comes to indexedDBRemoved() above
and hence the log is not generated. Same for indexedDBRemoved() &
indexedDBLoaded() functions.

But the control does come to IndexedDBTreeElement::_indexedDBAdded etc.
Could you please suggest how to go about fixing this. Thanks

[pfeldman, 2013-09-16 11:58:25]

The problem you had was that WebInspector.showPanel was actually triggering
model creation and fired all events before sniffers had a change to be
installed. The solution is to split initialization into panel creation and
calling show on it.

[vanihegde, 2013-09-17 03:03:34]

On 2013/09/16 11:58:25, pfeldman wrote:
> The problem you had was that WebInspector.showPanel was actually triggering
> model creation and fired all events before sniffers had a change to be
> installed. The solution is to split initialization into panel creation and
> calling show on it.

Thanks, that works. So shall we commit this?

[commit-bot: I haz the power, 2013-09-18 07:47:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/24109003/17002

[pfeldman, 2013-09-18 07:48:33]

Sorry for uploading the change instead of directing you the right way - turned
out it required a lot tweaking and it seemed easier to upload what I ended up
with.

[commit-bot: I haz the power, 2013-09-18 10:31:17]

Change committed as 157951