Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 24109002: [InfoBar] Upstram basic infobar flow for Android. (Closed)

Created:
7 years, 3 months ago by Miguel Garcia
Modified:
7 years, 3 months ago
Reviewers:
Yaron, gone, yfriedman
CC:
chromium-reviews, Peter Kasting
Base URL:
https://chromium.googlesource.com/chromium/src.git@upstream_infobar_full
Visibility:
Public.

Description

[InfoBar] Upstram basic infobar flow for Android. The Translate infobar and the relevant tests remain downstream for now BUG=158817 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223651

Patch Set 1 #

Patch Set 2 : Fix Copyright year everywhere #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : Fix License header in two more files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3820 lines, -116 lines) Patch
A + chrome/android/java/res/drawable/infobar_button_normal_floating.xml View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
A + chrome/android/java/res/drawable/infobar_button_normal_full_left.xml View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
A + chrome/android/java/res/drawable/infobar_button_normal_full_right.xml View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
A + chrome/android/java/res/drawable/infobar_button_text.xml View 1 2 3 4 1 chunk +7 lines, -4 lines 0 comments Download
A + chrome/android/java/res/drawable/infobar_button_warning_floating.xml View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
A + chrome/android/java/res/drawable/infobar_button_warning_full_left.xml View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
A + chrome/android/java/res/drawable/infobar_button_warning_full_right.xml View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
A chrome/android/java/res/drawable/infobar_close_bg.xml View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/android/java/res/drawable/infobar_close_button_focused.xml View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A + chrome/android/java/res/drawable/infobar_close_button_pressed.xml View 1 2 3 4 1 chunk +7 lines, -3 lines 0 comments Download
A + chrome/android/java/res/drawable/infobar_info_background.xml View 1 2 3 4 1 chunk +9 lines, -4 lines 0 comments Download
A + chrome/android/java/res/drawable/infobar_warning_background.xml View 1 2 3 4 1 chunk +9 lines, -4 lines 0 comments Download
A chrome/android/java/res/layout/dimens.xml View 1 chunk +251 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/infobar_button.xml View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/infobar_text.xml View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/android/java/res/values/colors.xml View 1 chunk +87 lines, -0 lines 0 comments Download
A chrome/android/java/res/values/values.xml View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/AnimationHelper.java View 1 chunk +244 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoLoginAccountDelegate.java View 1 2 1 chunk +92 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoLoginDelegate.java View 1 3 1 chunk +107 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoLoginProcessor.java View 1 2 3 4 5 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java View 1 1 chunk +77 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBarDelegate.java View 1 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java View 1 chunk +254 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java View 1 1 chunk +265 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 1 2 1 chunk +522 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java View 1 2 3 4 5 1 chunk +775 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarListeners.java View 1 chunk +28 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarView.java View 1 chunk +62 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/MessageInfoBar.java View 1 1 chunk +69 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/infobar/TwoButtonInfoBar.java View 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/testshell/testshell_stubs.cc View 2 chunks +0 lines, -35 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android_test_stubs.cc View 1 chunk +0 lines, -35 lines 0 comments Download
A chrome/browser/ui/android/infobar/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/android/infobar/auto_login_infobar_delegate_android.cc View 1 chunk +123 lines, -0 lines 0 comments Download
A chrome/browser/ui/android/infobar/confirm_infobar.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/ui/android/infobar/confirm_infobar.cc View 1 1 chunk +83 lines, -0 lines 0 comments Download
A chrome/browser/ui/android/infobar/infobar_android.h View 1 1 chunk +87 lines, -0 lines 0 comments Download
A chrome/browser/ui/android/infobar/infobar_android.cc View 1 1 chunk +100 lines, -0 lines 0 comments Download
A chrome/browser/ui/android/infobar/infobar_container_android.h View 1 1 chunk +69 lines, -0 lines 0 comments Download
A chrome/browser/ui/android/infobar/infobar_container_android.cc View 1 1 chunk +124 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M ui/android/java/res/values/dimens.xml View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Miguel Garcia
Some notes: This Cl depends on https://codereview.chromium.org/23956008/ -> upstream the resources https://gerrit-int.chromium.org/#/c/44188/ to remove the ...
7 years, 3 months ago (2013-09-16 11:27:54 UTC) #1
Yaron
On 2013/09/16 11:27:54, Miguel Garcia wrote: > Some notes: > > This Cl depends on ...
7 years, 3 months ago (2013-09-17 01:45:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/24109002/11001
7 years, 3 months ago (2013-09-17 13:27:16 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=25839
7 years, 3 months ago (2013-09-17 13:43:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/24109002/23001
7 years, 3 months ago (2013-09-17 14:58:25 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-17 15:06:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/24109002/23001
7 years, 3 months ago (2013-09-17 15:11:43 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 19:06:21 UTC) #8
Message was sent while issue was closed.
Change committed as 223651

Powered by Google App Engine
This is Rietveld 408576698