Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2410893006: Remove usage of base::ObserverList<T>::Iter::GetNext() in //components/renderer_context_menu. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, loyso (OOO)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of base::ObserverList<T>::Iter::GetNext() in //components/renderer_context_menu. Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/9f2c0c22727611cc5f812c7597522d0fcf769c66 Cr-Commit-Position: refs/heads/master@{#424928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M components/renderer_context_menu/render_view_context_menu_base.cc View 3 chunks +9 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dcheng
4 years, 2 months ago (2016-10-12 23:34:08 UTC) #4
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-13 01:19:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410893006/1
4 years, 2 months ago (2016-10-13 01:20:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 01:25:19 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 01:28:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f2c0c22727611cc5f812c7597522d0fcf769c66
Cr-Commit-Position: refs/heads/master@{#424928}

Powered by Google App Engine
This is Rietveld 408576698