Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2410893003: [turbofan] Respect ConsString invariant. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Respect ConsString invariant. For ConsString, the left hand side must be either sequential or external if the right hand side is empty. R=jarin@chromium.org BUG=chromium:654723 NOTRY=true Committed: https://crrev.com/a4f37da86f428de5ee75a6a093416f35d5561150 Cr-Commit-Position: refs/heads/master@{#40192}

Patch Set 1 #

Patch Set 2 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 1 chunk +11 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-654723.js View 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-12 05:13:07 UTC) #1
Jarin
lgtm
4 years, 2 months ago (2016-10-12 05:16:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410893003/20001
4 years, 2 months ago (2016-10-12 05:17:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_sanitizer_coverage_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_sanitizer_coverage_rel/builds/10125)
4 years, 2 months ago (2016-10-12 06:08:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410893003/20001
4 years, 2 months ago (2016-10-12 06:30:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410893003/20001
4 years, 2 months ago (2016-10-12 06:58:55 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 07:00:39 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 07:01:00 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4f37da86f428de5ee75a6a093416f35d5561150
Cr-Commit-Position: refs/heads/master@{#40192}

Powered by Google App Engine
This is Rietveld 408576698