Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2410893002: Merge CPDFSDK_Document into CPDFSDK_FormFillEnvironment (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Merge CPDFSDK_Document into CPDFSDK_FormFillEnvironment This CL merges the CPDFSDK_Document and CPDFSDK_FormFillEnvironment classes as they always existed and always pointed at each other. Committed: https://pdfium.googlesource.com/pdfium/+/7cbe68e34257b460bfa3baf0ea68fd6d50e1bc77

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove methods #

Patch Set 3 : Rebase to master #

Patch Set 4 : Rebase to master #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -623 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/cfx_systemhandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannot.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D fpdfsdk/cpdfsdk_document.h View 1 chunk +0 lines, -105 lines 0 comments Download
D fpdfsdk/cpdfsdk_document.cpp View 1 chunk +0 lines, -247 lines 0 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.h View 1 5 chunks +71 lines, -7 lines 6 comments Download
M fpdfsdk/cpdfsdk_formfillenvironment.cpp View 1 2 3 3 chunks +214 lines, -3 lines 4 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 1 7 chunks +11 lines, -14 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 8 chunks +9 lines, -12 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 9 chunks +8 lines, -16 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 1 3 chunks +2 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 5 chunks +6 lines, -7 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 3 chunks +2 lines, -4 lines 0 comments Download
M fpdfsdk/formfiller/cffl_interactiveformfiller.cpp View 1 7 chunks +7 lines, -10 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 10 chunks +13 lines, -18 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 15 chunks +23 lines, -27 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_document.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 1 6 chunks +9 lines, -17 lines 0 comments Download
M fpdfsdk/fsdk_baseform_embeddertest.cpp View 1 4 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 30 chunks +45 lines, -65 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 20 chunks +26 lines, -44 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 1 4 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-11 14:07:50 UTC) #2
Tom Sepez
https://codereview.chromium.org/2410893002/diff/1/fpdfsdk/cpdfsdk_formfillenvironment.h File fpdfsdk/cpdfsdk_formfillenvironment.h (right): https://codereview.chromium.org/2410893002/diff/1/fpdfsdk/cpdfsdk_formfillenvironment.h#newcode216 fpdfsdk/cpdfsdk_formfillenvironment.h:216: CPDFSDK_FormFillEnvironment* GetSDKDocument() { return this; } Do we need ...
4 years, 2 months ago (2016-10-11 16:41:09 UTC) #3
Tom Sepez
On 2016/10/11 16:41:09, Tom Sepez wrote: > https://codereview.chromium.org/2410893002/diff/1/fpdfsdk/cpdfsdk_formfillenvironment.h > File fpdfsdk/cpdfsdk_formfillenvironment.h (right): > > https://codereview.chromium.org/2410893002/diff/1/fpdfsdk/cpdfsdk_formfillenvironment.h#newcode216 ...
4 years, 2 months ago (2016-10-11 16:48:39 UTC) #4
dsinclair
PTAL.
4 years, 2 months ago (2016-10-11 21:18:19 UTC) #7
dsinclair
ping.
4 years, 2 months ago (2016-10-12 12:51:14 UTC) #10
Tom Sepez
LGTM with a bunch of nits for follow-on. https://codereview.chromium.org/2410893002/diff/60001/fpdfsdk/cpdfsdk_formfillenvironment.cpp File fpdfsdk/cpdfsdk_formfillenvironment.cpp (right): https://codereview.chromium.org/2410893002/diff/60001/fpdfsdk/cpdfsdk_formfillenvironment.cpp#newcode50 fpdfsdk/cpdfsdk_formfillenvironment.cpp:50: for ...
4 years, 2 months ago (2016-10-12 18:53:00 UTC) #13
dsinclair
On 2016/10/12 18:53:00, Tom Sepez wrote: > LGTM with a bunch of nits for follow-on. ...
4 years, 2 months ago (2016-10-12 18:55:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410893002/60001
4 years, 2 months ago (2016-10-12 18:56:06 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://pdfium.googlesource.com/pdfium/+/7cbe68e34257b460bfa3baf0ea68fd6d50e1bc77
4 years, 2 months ago (2016-10-12 18:56:27 UTC) #18
dsinclair
4 years, 2 months ago (2016-10-12 19:44:29 UTC) #19
Message was sent while issue was closed.
Nits fixed in https://codereview.chromium.org/2417633002/

https://codereview.chromium.org/2410893002/diff/60001/fpdfsdk/cpdfsdk_formfil...
File fpdfsdk/cpdfsdk_formfillenvironment.cpp (right):

https://codereview.chromium.org/2410893002/diff/60001/fpdfsdk/cpdfsdk_formfil...
fpdfsdk/cpdfsdk_formfillenvironment.cpp:50: for (auto& it : m_pageMap)
On 2016/10/12 18:52:59, Tom Sepez wrote:
> nit: map of unique_ptrs (keep .clear() if order important)

Done.

https://codereview.chromium.org/2410893002/diff/60001/fpdfsdk/cpdfsdk_formfil...
fpdfsdk/cpdfsdk_formfillenvironment.cpp:587: bool ReNew) {
On 2016/10/12 18:52:59, Tom Sepez wrote:
> nit: |renew| or |bRenew|  (has bugged me for years)

Done.

https://codereview.chromium.org/2410893002/diff/60001/fpdfsdk/cpdfsdk_formfil...
File fpdfsdk/cpdfsdk_formfillenvironment.h (right):

https://codereview.chromium.org/2410893002/diff/60001/fpdfsdk/cpdfsdk_formfil...
fpdfsdk/cpdfsdk_formfillenvironment.h:37: CPDFSDK_InterForm* GetInterForm();
On 2016/10/12 18:52:59, Tom Sepez wrote:
> nit: const method?

Can't, creates if doesn't exist. Moved down with other similar methods and added
a comment.

https://codereview.chromium.org/2410893002/diff/60001/fpdfsdk/cpdfsdk_formfil...
fpdfsdk/cpdfsdk_formfillenvironment.h:90: FX_BOOL GetChangeMark() { return
m_bChangeMask; }
On 2016/10/12 18:52:59, Tom Sepez wrote:
> nit: const method.

Done.

https://codereview.chromium.org/2410893002/diff/60001/fpdfsdk/cpdfsdk_formfil...
fpdfsdk/cpdfsdk_formfillenvironment.h:236: FX_BOOL m_bChangeMask;
On 2016/10/12 18:53:00, Tom Sepez wrote:
> nit: bool (next line too)

Done.

Powered by Google App Engine
This is Rietveld 408576698