src/compiler/representation-change.cc - Issue 2410883003: [turbofan] Remove minus zero check for rhs of CheckedInt32Sub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/representation-change.cc

Issue 2410883003: [turbofan] Remove minus zero check for rhs of CheckedInt32Sub. (Closed)

Patch Set: Adding TODO. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/representation-change.cc

diff --git a/src/compiler/representation-change.cc b/src/compiler/representation-change.cc

index 22d809b9d676492149d604336de71549576db2e0..6aa2f133a2be0ff3935ed216e5ca1f8aeb2952e8 100644

--- a/src/compiler/representation-change.cc

+++ b/src/compiler/representation-change.cc

@@ -587,7 +587,7 @@ Node* RepresentationChanger::GetWord32RepresentationFor(

use_info.type_check() == TypeCheckKind::kSigned32) {

op = simplified()->CheckedFloat64ToInt32(

output_type->Maybe(Type::MinusZero())

- ? CheckForMinusZeroMode::kCheckForMinusZero

+ ? use_info.minus_zero_check()

: CheckForMinusZeroMode::kDontCheckForMinusZero);

}

} else if (output_rep == MachineRepresentation::kFloat32) {

« no previous file with comments | « src/compiler/representation-change.h ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »