Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2410863006:
Disable network-disable-cache-preloads.php on Win7 (dbg) (Closed)
|
Created:
4 years, 2 months ago by msramek Modified:
4 years, 2 months ago Reviewers:
Yoav Weiss CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable network-disable-cache-preloads.php on Win7 (dbg)
NOTRY=true
TBR=yoav@yoav.ws
BUG=652187
Committed: https://crrev.com/50c7b3ce18404e7b0002b0a7a7fc325fb3e0854b
Cr-Commit-Position: refs/heads/master@{#424992}
Patch Set 1 #Patch Set 2 : Rebase. #Messages
Total messages: 17 (9 generated)
As mentioned in crbug.com/652187, I'll disable the tests on Win7 for now. Yoav, please look into it soon.
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/13 08:47:38, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Lgtm. I'll take a look at it later today/tomorrow
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1224 Falling back to three-way merge... Applied patch to 'third_party/WebKit/LayoutTests/TestExpectations' with conflicts. U third_party/WebKit/LayoutTests/TestExpectations Patch: third_party/WebKit/LayoutTests/TestExpectations Index: third_party/WebKit/LayoutTests/TestExpectations diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations index 565916ba625a872aa950e83f7221e25bd2a85e8d..a7fc5e9120a8986ec3264ff22a958f8dd473f2b4 100644 --- a/third_party/WebKit/LayoutTests/TestExpectations +++ b/third_party/WebKit/LayoutTests/TestExpectations @@ -1224,3 +1224,5 @@ crbug.com/646323 [ Mac ] editing/selection/modify_move/move_backward_line_import crbug.com/646323 [ Win Linux ] editing/selection/modify_move/move_backward_line_import_crash.html [ Crash ] crbug.com/645640 inspector/extensions/extensions-eval.html [ NeedsManualRebaseline ] + +crbug.com/652187 [ Win7 Debug ] http/tests/inspector/network/network-disable-cache-preloads.php [ Failure ]
The CQ bit was checked by msramek@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws Link to the patchset: https://codereview.chromium.org/2410863006/#ps20001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by msramek@chromium.org
Description was changed from ========== Disable network-disable-cache-preloads.php on Win7 (dbg) TBR=yoav@yoav.ws BUG=652187 ========== to ========== Disable network-disable-cache-preloads.php on Win7 (dbg) NOTRY=true TBR=yoav@yoav.ws BUG=652187 ==========
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Disable network-disable-cache-preloads.php on Win7 (dbg) NOTRY=true TBR=yoav@yoav.ws BUG=652187 ========== to ========== Disable network-disable-cache-preloads.php on Win7 (dbg) NOTRY=true TBR=yoav@yoav.ws BUG=652187 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable network-disable-cache-preloads.php on Win7 (dbg) NOTRY=true TBR=yoav@yoav.ws BUG=652187 ========== to ========== Disable network-disable-cache-preloads.php on Win7 (dbg) NOTRY=true TBR=yoav@yoav.ws BUG=652187 Committed: https://crrev.com/50c7b3ce18404e7b0002b0a7a7fc325fb3e0854b Cr-Commit-Position: refs/heads/master@{#424992} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/50c7b3ce18404e7b0002b0a7a7fc325fb3e0854b Cr-Commit-Position: refs/heads/master@{#424992} |
