Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 2410863004: DBC: Use type cache for more checks (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Use type cache for more checks Flutter layout benchmark ~10.5k us -> ~8.5k us for a total 1.76x improvement on the day =) R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/da388d21c6f1a791e8f9f251c43c78fd127252d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M runtime/vm/flow_graph_compiler_dbc.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
4 years, 2 months ago (2016-10-11 21:57:14 UTC) #3
Florian Schneider
lgtm
4 years, 2 months ago (2016-10-11 22:04:23 UTC) #4
zra
4 years, 2 months ago (2016-10-11 22:20:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da388d21c6f1a791e8f9f251c43c78fd127252d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698