Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2410853002: Revert of gclient: kill git fetch operation that hangs. (Closed)

Created:
4 years, 2 months ago by tandrii(chromium)
Modified:
4 years, 2 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of gclient: kill git fetch operation that hangs. (patchset #12 id:220001 of https://codereview.chromium.org/2241843002/ ) Reason for revert: Didn't help. Original issue's description: > gclient: kill git fetch operation that hangs. > > This provides env variable GCLIENT_KILL_GIT_FETCH_AFTER > that kills git fetch if it produces no output for that > many seconds. > > Note that this is not final patch, but an experiment. > See http://crbug.com/635641#c24 for the deployment plan. > > BUG=635641 > R=hinoka@chromium.org > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f8757b7e02226594655230ccbeae3543c7dc49c6 TBR=hinoka@chromium.org,hinoka@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635641 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/64103db7286bc23f00e7c464c9b087a68fcff522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -193 lines) Patch
M gclient_scm.py View 2 chunks +1 line, -3 lines 0 comments Download
M gclient_utils.py View 4 chunks +1 line, -65 lines 0 comments Download
M tests/gclient_scm_test.py View 2 chunks +0 lines, -62 lines 0 comments Download
M tests/gclient_utils_test.py View 3 chunks +0 lines, -63 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tandrii(chromium)
Created Revert of gclient: kill git fetch operation that hangs.
4 years, 2 months ago (2016-10-11 12:16:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410853002/1
4 years, 2 months ago (2016-10-11 12:16:32 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/31cc7e8983a74c10)
4 years, 2 months ago (2016-10-11 12:18:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410853002/1
4 years, 2 months ago (2016-10-11 12:26:53 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 12:30:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/64103db7286bc2...

Powered by Google App Engine
This is Rietveld 408576698