Linux Aura: Use managed tab dragging when possible (Reland)

ui/base/x/x11_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_X_X11_UTIL_H_
 #define UI_BASE_X_X11_UTIL_H_
 
 // This file declares utility functions for X11 (Linux only).
 //
 // These functions do not require the Xlib headers to be included (which is why
@@ skipping 19 matching lines @@
 namespace gfx {
 class Canvas;
 class Insets;
 class Point;
 class Rect;
 }
 class SkBitmap;
 
 namespace ui {
 
+enum class NetWmMoveResize {

[Daniel Erat, 2016/10/12 16:13:10]

nit: add a comment saying that these must match the hardcoded values from ewmh's
_NET_WM_MOVERESIZE spec, and consider explicitly numbering them (or at least
explicitly setting TOPLEFT to 0)

[Tom (Use chromium acct), 2016/10/12 18:08:27]

Done.

+  SIZE_TOPLEFT,
+  SIZE_TOP,
+  SIZE_TOPRIGHT,
+  SIZE_RIGHT,
+  SIZE_BOTTOMRIGHT,
+  SIZE_BOTTOM,
+  SIZE_BOTTOMLEFT,
+  SIZE_LEFT,
+  MOVE,           // movement only
+  SIZE_KEYBOARD,  // size via keyboard
+  MOVE_KEYBOARD,  // move via keyboard
+  CANCEL,         // cancel operation
+};
+
 // These functions use the default display and this /must/ be called from
 // the UI thread. Thus, they don't support multiple displays.
 
 // These functions cache their results ---------------------------------
 
 // Returns true if the system supports XINPUT2.
 UI_BASE_X_EXPORT bool IsXInput2Available();
 
 // Return true iff the display supports Xrender
 UI_BASE_X_EXPORT bool QueryRenderSupport(XDisplay* dpy);
@@ skipping 27 matching lines @@
 
 // Hides the host cursor.
 UI_BASE_X_EXPORT void HideHostCursor();
 
 // Returns an invisible cursor.
 UI_BASE_X_EXPORT::Cursor CreateInvisibleCursor();
 
 // Sets whether |window| should use the OS window frame.
 UI_BASE_X_EXPORT void SetUseOSWindowFrame(XID window, bool use_os_window_frame);
 
+// Requests the window manager move or resize the window on behalf of Chromium.
+// Clients MUST release all grabs prior to calling.

[Daniel Erat, 2016/10/12 16:13:10]

maybe document that this isn't implemented by all window managers (perhaps
explicitly calling out tiling ones) and that the caller should check for support
first.

[Tom (Use chromium acct), 2016/10/12 18:08:27]

Done.

+UI_BASE_X_EXPORT void MoveResizeWindowManaged(XID window,

[Daniel Erat, 2016/10/12 16:13:10]

nit: change "WindowManaged" to "ManagedWindow"?

[Tom (Use chromium acct), 2016/10/12 18:08:27]

Done.

+                                              gfx::Point origin,

[Daniel Erat, 2016/10/12 16:13:10]

per the spec, this is actually the pointer position relative to the root
window's origin at the start of the operation, right? if that's correct, please
name it something like |event_root| and document it in the comment.

[Tom (Use chromium acct), 2016/10/12 18:08:27]

Done.

+                                              NetWmMoveResize mode);
+
 // These functions do not cache their results --------------------------
 
 // Returns true if the shape extension is supported.
 UI_BASE_X_EXPORT bool IsShapeExtensionAvailable();
 
 // Get the X window id for the default root window
 UI_BASE_X_EXPORT XID GetX11RootWindow();
 
 // Returns the user's current desktop.
 UI_BASE_X_EXPORT bool GetCurrentDesktop(int* desktop);
@@ skipping 232 matching lines @@
 UI_BASE_X_EXPORT void ResetXCursorCache();
 
 // Returns the cached XcursorImage for |cursor|.
 UI_BASE_X_EXPORT const XcursorImage* GetCachedXcursorImage(::Cursor cursor);
 
 }  // namespace test
 
 }  // namespace ui
 
 #endif  // UI_BASE_X_X11_UTIL_H_