[wasm] GrowMemory should use maximum size declared in WebAssembly.Memory

test/mjsunit/wasm/import-memory.js

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Flags: --expose-wasm
 
 load("test/mjsunit/wasm/wasm-constants.js");
 load("test/mjsunit/wasm/wasm-module-builder.js");
 
 (function TestOne() {
@@ skipping 64 matching lines @@
     for (var j = 0; j < 10; j++) {
       var val = i + 99077 + j;
       i32[j] = val;
       assertEquals(val | 0, i1.exports.foo(j * 4));
       assertEquals(val | 0, i2.exports.bar(j * 4));
     }
   }
 })();
 
 (function ValidateBoundsCheck() {
-  print("Validate bounds check");
+  print("ValidateBoundsCheck");
   let memory = new WebAssembly.Memory({initial: 1, maximum: 5});
   assertEquals(kPageSize, memory.buffer.byteLength);
   let i32 = new Int32Array(memory.buffer);
   let builder = new WasmModuleBuilder();
   // builder.addImportedMemory("mine");
   builder.addImportedMemory("mine");
   builder.addFunction("load", kSig_i_i)
       .addBody([kExprGetLocal, 0, kExprI32LoadMem, 0, 0])
       .exportFunc();
   builder.addFunction("store", kSig_i_ii)
       .addBody([kExprGetLocal, 0, kExprGetLocal, 1, kExprI32StoreMem, 0, 0,
                 kExprGetLocal, 1])
       .exportFunc();
   var offset;
   let instance = builder.instantiate({mine: memory});
   function load() { return instance.exports.load(offset); }
   function store(value) { return instance.exports.store(offset, value); }
 
   for (offset = 0; offset < kPageSize -3; offset+=4) {
     store(offset);
   }
   for (offset = 0; offset < kPageSize - 3; offset+=4) {
     assertEquals(offset, load());
   }
   for (offset = kPageSize - 3; offset < kPageSize + 4; offset++) {
     assertTraps(kTrapMemOutOfBounds, load);
   }
 })();
+
+(function TestGrowMemoryMaxDesc() {
+  print("MaximumDescriptor");
+  let memory = new WebAssembly.Memory({initial: 1, maximum: 5});
+  assertEquals(kPageSize, memory.buffer.byteLength);
+  let i32 = new Int32Array(memory.buffer);
+  let builder = new WasmModuleBuilder();
+  builder.addImportedMemory("mine");
+  builder.addFunction("load", kSig_i_i)
+      .addBody([kExprGetLocal, 0, kExprI32LoadMem, 0, 0])
+      .exportFunc();
+  builder.addFunction("store", kSig_i_ii)
+      .addBody([kExprGetLocal, 0, kExprGetLocal, 1, kExprI32StoreMem, 0, 0,
+                kExprGetLocal, 1])
+      .exportFunc();
+  var offset;
+  let instance = builder.instantiate({mine: memory});
+  function load() { return instance.exports.load(offset); }
+  function store(value) { return instance.exports.store(offset, value); }
+
+  for (var i = 1; i < 5; i++) {
+    for (offset = (i-1)*kPageSize; offset < i*kPageSize - 3; offset+=4) {

[bradnelson, 2016/10/17 22:13:25]

Spacing on these operators is weird.
https://google.github.io/styleguide/javascriptguide.xml

[gdeepti, 2016/10/18 02:34:17]

Done.

+      store(offset*2);
+    }
+    assertEquals(i, memory.grow(1));
+    assertEquals((i+1)*kPageSize, memory.buffer.byteLength);
+  }
+  for (offset = 4*kPageSize; offset < 5*kPageSize - 3; offset+=4) {
+    store(offset*2);
+  }
+
+  for (offset = 0; offset < 5*kPageSize - 3; offset+=4) {
+    assertEquals(offset*2, load());
+  }
+
+  for (offset = 5*kPageSize; offset < 5*kPageSize + 4; offset++) {
+    assertWasmError(load);
+  }
+   assertWasmError(memory.grow);
+})();
+
+(function TestGrowMemoryZeroInitialMemory() {
+  print("ZeroInitialMemory");
+  let memory = new WebAssembly.Memory({initial: 0});
+  assertEquals(0, memory.buffer.byteLength);
+  let i32 = new Int32Array(memory.buffer);
+  let builder = new WasmModuleBuilder();
+  builder.addImportedMemory("mine");
+  builder.addFunction("load", kSig_i_i)
+      .addBody([kExprGetLocal, 0, kExprI32LoadMem, 0, 0])
+      .exportFunc();
+  builder.addFunction("store", kSig_i_ii)
+      .addBody([kExprGetLocal, 0, kExprGetLocal, 1, kExprI32StoreMem, 0, 0,
+                kExprGetLocal, 1])
+      .exportFunc();
+  var offset;
+  let instance = builder.instantiate({mine: memory});
+  function load() { return instance.exports.load(offset); }
+  function store(value) { return instance.exports.store(offset, value); }
+
+  for (var i = 1; i < 5; i++) {
+    assertEquals(i - 1, memory.grow(1));
+    assertEquals(i*kPageSize, memory.buffer.byteLength);
+    for (offset = (i-1)*kPageSize; offset < i*kPageSize - 3; offset++) {
+      store(offset*2);
+    }
+  }
+  for (offset = 5*kPageSize; offset < 5*kPageSize + 4; offset++) {
+    assertWasmError(load);
+  }
+  try {
+    memory.grow(16381);

[bradnelson, 2016/10/17 22:23:26]

Use assertThrows here?

[gdeepti, 2016/10/18 02:34:17]

Done.

+  } catch (e) {
+    assertEquals("object", typeof e);
+  }
+})();

[bradnelson, 2016/10/17 22:23:26]

Add tests of:
* Memory initial smaller than module imported memory initial.
* Memory max larger than module max size (dynamic).

[gdeepti, 2016/10/18 02:34:17]

Deferring this to another change because as per my understanding this isn't
completely implemented just yet.