Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2410753002: Remove ResourceTest.ProhibitAddRemoveClientInScope unit test (Closed)

Created:
4 years, 2 months ago by Shao-Chuan Lee
Modified:
4 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ResourceTest.ProhibitAddRemoveClientInScope unit test Remove this unit test for now, we'll have tests for actual usage of ProhibitAddRemoveClientInScope. Also reverting changes for unit tests in d9143c64. BUG=654424 Committed: https://crrev.com/ae00c62ebebe09617a893da5f920ac735e3fbb3c Cr-Commit-Position: refs/heads/master@{#424421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M third_party/WebKit/Source/core/fetch/MockResourceClients.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceTest.cpp View 3 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Shao-Chuan Lee
PTAL
4 years, 2 months ago (2016-10-11 03:38:51 UTC) #2
Nico
lgtm, thanks
4 years, 2 months ago (2016-10-11 13:46:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410753002/1
4 years, 2 months ago (2016-10-11 13:47:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 14:40:57 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 14:43:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae00c62ebebe09617a893da5f920ac735e3fbb3c
Cr-Commit-Position: refs/heads/master@{#424421}

Powered by Google App Engine
This is Rietveld 408576698