Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2410733002: Teach determinism tools about the new storage_unittests target. (Closed)

Created:
4 years, 2 months ago by pwnall
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Teach determinism tools about the new storage_unittests target. BUG=653751 Committed: https://crrev.com/3387d2697f8df0030805ad9218a217f767e1700e Cr-Commit-Position: refs/heads/master@{#424772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/determinism/compare_build_artifacts.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
pwnall
PTAL?
4 years, 2 months ago (2016-10-11 03:17:14 UTC) #3
pwnall
PTAL?
4 years, 2 months ago (2016-10-11 03:17:47 UTC) #5
pwnall
Switching reviewers because thakis@ signaled that he is busy. yyanagisawa@: PTAL?
4 years, 2 months ago (2016-10-12 04:33:19 UTC) #11
Yoshisato Yanagisawa
lgtm Linked binaries cannot be deterministic on mac and windows, as far as I know. ...
4 years, 2 months ago (2016-10-12 04:48:49 UTC) #12
pwnall
On 2016/10/12 04:48:49, Yoshisato Yanagisawa wrote: > lgtm > > Linked binaries cannot be deterministic ...
4 years, 2 months ago (2016-10-12 17:09:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410733002/1
4 years, 2 months ago (2016-10-12 17:09:46 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 17:24:18 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 17:49:31 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3387d2697f8df0030805ad9218a217f767e1700e
Cr-Commit-Position: refs/heads/master@{#424772}

Powered by Google App Engine
This is Rietveld 408576698