|
|
Chromium Code Reviews
DescriptionTeach determinism tools about the new storage_unittests target.
BUG=653751
Committed: https://crrev.com/3387d2697f8df0030805ad9218a217f767e1700e
Cr-Commit-Position: refs/heads/master@{#424772}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by pwnall@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL?
pwnall@chromium.org changed reviewers: + thakis@chromium.org
PTAL?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Teach determinism tools about the new storage_unittests target. BUG=653751 ========== to ========== Teach determinism tools about the new storage_unittests target. BUG=653751 ==========
pwnall@chromium.org changed reviewers: - thakis@chromium.org
pwnall@chromium.org changed reviewers: + yyanagisawa@google.com
Switching reviewers because thakis@ signaled that he is busy. yyanagisawa@: PTAL?
lgtm Linked binaries cannot be deterministic on mac and windows, as far as I know. It should be fine to opt-out any binaries until the cause is fixed.
On 2016/10/12 04:48:49, Yoshisato Yanagisawa wrote: > lgtm > > Linked binaries cannot be deterministic on mac and windows, as far as I know. > It should be fine to opt-out any binaries until the cause is fixed. Thank you for the explanation and for the quick turnaround!
The CQ bit was checked by pwnall@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Teach determinism tools about the new storage_unittests target. BUG=653751 ========== to ========== Teach determinism tools about the new storage_unittests target. BUG=653751 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Teach determinism tools about the new storage_unittests target. BUG=653751 ========== to ========== Teach determinism tools about the new storage_unittests target. BUG=653751 Committed: https://crrev.com/3387d2697f8df0030805ad9218a217f767e1700e Cr-Commit-Position: refs/heads/master@{#424772} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3387d2697f8df0030805ad9218a217f767e1700e Cr-Commit-Position: refs/heads/master@{#424772} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
