third_party/WebKit/Source/core/frame/FrameSerializer.cpp - Issue 2410693002: Add a few more edge cases to CSS serialization test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameSerializer.cpp

Issue 2410693002: Add a few more edge cases to CSS serialization test. (Closed)

Patch Set: Adds the case of a CSS already being included in another frame. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameSerializer.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameSerializer.cpp b/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

index fb3e8184bf2ee03f678319e2aab2f2a178f489bb..19b8f1b621a0c5cd81b4ad4a5cd83ed4c9f3f80b 100644

--- a/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

@@ -411,8 +411,6 @@ void FrameSerializer::serializeCSSRule(CSSRule* rule) {

KURL sheetBaseURL = rule->parentStyleSheet()->baseURL();

ASSERT(sheetBaseURL.isValid());

KURL importURL = KURL(sheetBaseURL, importRule->href());

- if (m_resourceURLs.contains(importURL))

- break;

carlosk 2016/10/11 23:08:54 This is not needed anymore as it's checked early i

if (importRule->styleSheet())

serializeCSSStyleSheet(*importRule->styleSheet(), importURL);

break;