Index: scripts/slave/recipe_modules/chromium_tests/steps.py |
diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py |
index 8b43368996bf93ceabfbda40497280f080b0f214..ddc0e5a629dd9f365e90ab00d80587538934c9f7 100644 |
--- a/scripts/slave/recipe_modules/chromium_tests/steps.py |
+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py |
@@ -1097,6 +1097,16 @@ class SwarmingIsolatedScriptTest(SwarmingTest): |
for res in tests[t]['actual'].split())) |
return True, failures |
+ def upload_json_format_results(self, api, results): |
+ chrome_revision_cp = api.bot_update.last_returned_properties.get( |
+ 'got_revision_cp', 'x@{#0}') |
+ chrome_revision = str(api.commit_position.parse_revision( |
+ chrome_revision_cp)) |
+ api.test_results.upload( |
+ api.json.input(results), chrome_revision=chrome_revision, |
+ test_type=self.name, |
+ test_results_server='test-results.appspot.com') |
+ |
def validate_task_results(self, api, step_result): |
results = getattr(step_result, 'isolated_script_results', None) or {} |
valid = True |
@@ -1117,6 +1127,10 @@ class SwarmingIsolatedScriptTest(SwarmingTest): |
step_result.presentation.step_text += api.test_utils.format_step_text([ |
['failures:', failures] |
]) |
+ # Only upload json format results. |
Sergiy Byelozyorov
2016/10/11 14:39:29
Why is it done in validate_task_results? What if t
Paweł Hajdan Jr.
2016/10/11 18:04:11
+1 ; post_run would be better place
nednguyen
2016/10/13 17:58:03
Swarming.post_run(..) calls validate_task_results:
|
+ if results.get('version', 0) == 3: |
+ self.upload_json_format_results(api, results) |
+ |
# Check for chartjson results and upload to results dashboard if present. |
self._output_chartjson_results_if_present(api, step_result) |
return valid, failures |