Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2410583002: Test update OCMock (Closed)

Created:
4 years, 2 months ago by gambard
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test update OCMock BUG=

Patch Set 1 #

Patch Set 2 : git cl web #

Patch Set 3 : patch #

Patch Set 4 : OCMock 3.1.5 #

Patch Set 5 : Re-patch #

Patch Set 6 : Repatch #

Patch Set 7 : Rebase #

Patch Set 8 : After cleanup #

Patch Set 9 : Use patched BoxedReturnValueProvider #

Patch Set 10 : Patch in exactly 3.1.5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3668 lines, -1348 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/password_controller_unittest.mm View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/password_generation_agent_unittest.mm View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/ocmock/BUILD.gn View 1 2 3 4 5 6 7 8 9 3 chunks +24 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/NSInvocation+OCMAdditions.h View 1 2 3 4 5 6 7 8 9 1 chunk +37 lines, -24 lines 0 comments Download
M third_party/ocmock/OCMock/NSInvocation+OCMAdditions.m View 1 2 3 4 5 6 7 8 9 2 chunks +310 lines, -286 lines 0 comments Download
M third_party/ocmock/OCMock/NSMethodSignature+OCMAdditions.h View 1 2 3 4 5 6 7 8 9 2 chunks +18 lines, -5 lines 0 comments Download
M third_party/ocmock/OCMock/NSMethodSignature+OCMAdditions.m View 1 2 3 4 5 6 7 8 9 1 chunk +52 lines, -11 lines 0 comments Download
M third_party/ocmock/OCMock/NSNotificationCenter+OCMAdditions.h View 1 2 3 4 5 6 7 8 9 1 chunk +19 lines, -7 lines 0 comments Download
M third_party/ocmock/OCMock/NSNotificationCenter+OCMAdditions.m View 1 2 3 4 5 6 7 8 9 2 chunks +23 lines, -7 lines 0 comments Download
A third_party/ocmock/OCMock/NSObject+OCMAdditions.h View 1 2 3 4 5 6 7 8 9 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/NSObject+OCMAdditions.m View 1 2 3 4 5 6 7 8 9 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/NSValue+OCMAdditions.h View 1 2 3 4 5 6 7 8 9 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/NSValue+OCMAdditions.m View 1 2 3 4 5 6 7 8 9 1 chunk +152 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCClassMockObject.h View 1 2 3 4 5 6 7 8 9 1 chunk +18 lines, -5 lines 0 comments Download
M third_party/ocmock/OCMock/OCClassMockObject.m View 1 2 3 4 5 6 7 8 9 4 chunks +237 lines, -10 lines 0 comments Download
M third_party/ocmock/OCMock/OCMArg.h View 1 2 3 4 5 6 7 8 9 3 chunks +32 lines, -8 lines 0 comments Download
M third_party/ocmock/OCMock/OCMArg.m View 1 2 3 4 5 6 7 8 9 5 chunks +48 lines, -14 lines 0 comments Download
M third_party/ocmock/OCMock/OCMBlockCaller.h View 1 2 3 4 5 6 7 8 9 2 chunks +15 lines, -6 lines 0 comments Download
M third_party/ocmock/OCMock/OCMBlockCaller.m View 1 2 3 4 5 6 7 8 9 2 chunks +23 lines, -11 lines 0 comments Download
M third_party/ocmock/OCMock/OCMBoxedReturnValueProvider.h View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMBoxedReturnValueProvider.m View 1 2 3 4 5 6 7 8 9 1 chunk +37 lines, -206 lines 0 comments Download
M third_party/ocmock/OCMock/OCMConstraint.h View 1 2 3 4 5 6 7 8 9 2 chunks +22 lines, -15 lines 0 comments Download
M third_party/ocmock/OCMock/OCMConstraint.m View 1 2 3 4 5 6 7 8 9 3 chunks +56 lines, -38 lines 0 comments Download
M third_party/ocmock/OCMock/OCMExceptionReturnValueProvider.h View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMExceptionReturnValueProvider.m View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -4 lines 0 comments Download
A third_party/ocmock/OCMock/OCMExpectationRecorder.h View 1 2 3 4 5 6 7 8 9 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMExpectationRecorder.m View 1 2 3 4 5 6 7 8 9 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMFunctions.h View 1 2 3 4 5 6 7 8 9 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMFunctions.m View 1 2 3 4 5 6 7 8 9 1 chunk +317 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCMIndirectReturnValueProvider.h View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMIndirectReturnValueProvider.m View 1 2 3 4 5 6 7 8 9 2 chunks +31 lines, -12 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationExpectation.h View 1 2 3 4 5 6 7 8 9 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationExpectation.m View 1 2 3 4 5 6 7 8 9 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationMatcher.h View 1 2 3 4 5 6 7 8 9 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationMatcher.m View 1 2 3 4 5 6 7 8 9 1 chunk +135 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationStub.h View 1 2 3 4 5 6 7 8 9 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMInvocationStub.m View 1 2 3 4 5 6 7 8 9 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMLocation.h View 1 2 3 4 5 6 7 8 9 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMLocation.m View 1 2 3 4 5 6 7 8 9 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMMacroState.h View 1 2 3 4 5 6 7 8 9 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMMacroState.m View 1 2 3 4 5 6 7 8 9 1 chunk +94 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCMNotificationPoster.h View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMNotificationPoster.m View 1 2 3 4 5 6 7 8 9 2 chunks +20 lines, -7 lines 0 comments Download
M third_party/ocmock/OCMock/OCMObserverRecorder.h View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMObserverRecorder.m View 1 2 3 4 5 6 7 8 9 2 chunks +26 lines, -23 lines 0 comments Download
M third_party/ocmock/OCMock/OCMPassByRefSetter.h View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMPassByRefSetter.m View 1 2 3 4 5 6 7 8 9 2 chunks +20 lines, -7 lines 0 comments Download
M third_party/ocmock/OCMock/OCMRealObjectForwarder.h View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCMRealObjectForwarder.m View 1 2 3 4 5 6 7 8 9 1 chunk +34 lines, -15 lines 0 comments Download
A third_party/ocmock/OCMock/OCMRecorder.h View 1 2 3 4 5 6 7 8 9 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMRecorder.m View 1 2 3 4 5 6 7 8 9 1 chunk +102 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCMReturnValueProvider.h View 1 2 3 4 5 6 7 8 9 2 chunks +16 lines, -5 lines 0 comments Download
M third_party/ocmock/OCMock/OCMReturnValueProvider.m View 1 2 3 4 5 6 7 8 9 2 chunks +36 lines, -14 lines 0 comments Download
A third_party/ocmock/OCMock/OCMStubRecorder.h View 1 2 3 4 5 6 7 8 9 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMStubRecorder.m View 1 2 3 4 5 6 7 8 9 1 chunk +161 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMVerifier.h View 1 2 3 4 5 6 7 8 9 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/ocmock/OCMock/OCMVerifier.m View 1 2 3 4 5 6 7 8 9 1 chunk +45 lines, -0 lines 0 comments Download
M third_party/ocmock/OCMock/OCMock.h View 1 2 3 4 5 6 7 8 9 1 chunk +69 lines, -5 lines 0 comments Download
M third_party/ocmock/OCMock/OCMock-Info.plist View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/ocmock/OCMock/OCMock-Prefix.pch View 1 2 3 4 5 6 7 8 9 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/ocmock/OCMock/OCMockObject.h View 1 2 3 4 5 6 7 8 9 3 chunks +41 lines, -11 lines 0 comments Download
M third_party/ocmock/OCMock/OCMockObject.m View 1 2 3 4 5 6 7 8 9 4 chunks +241 lines, -137 lines 0 comments Download
M third_party/ocmock/OCMock/OCMockRecorder.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -32 lines 0 comments Download
M third_party/ocmock/OCMock/OCMockRecorder.m View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -187 lines 0 comments Download
M third_party/ocmock/OCMock/OCObserverMockObject.h View 1 2 3 4 5 6 7 8 9 2 chunks +26 lines, -6 lines 0 comments Download
M third_party/ocmock/OCMock/OCObserverMockObject.m View 1 2 3 4 5 6 7 8 9 4 chunks +55 lines, -20 lines 0 comments Download
M third_party/ocmock/OCMock/OCPartialMockObject.h View 1 2 3 4 5 6 7 8 9 2 chunks +15 lines, -12 lines 0 comments Download
M third_party/ocmock/OCMock/OCPartialMockObject.m View 1 2 3 4 5 6 7 8 9 2 chunks +190 lines, -99 lines 0 comments Download
D third_party/ocmock/OCMock/OCPartialMockRecorder.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/ocmock/OCMock/OCPartialMockRecorder.m View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/ocmock/OCMock/OCProtocolMockObject.h View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -4 lines 0 comments Download
M third_party/ocmock/OCMock/OCProtocolMockObject.m View 1 2 3 4 5 6 7 8 9 2 chunks +31 lines, -17 lines 0 comments Download
A third_party/ocmock/OCMock/en.lproj/InfoPlist.strings View 1 2 3 4 5 6 7 8 9 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/ocmock/ocmock_extensions.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/ocmock/ocmock_extensions.mm View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 44 (44 generated)
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-10 19:54:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/1
4 years, 2 months ago (2016-10-10 19:54:34 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-10 20:24:46 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/83925)
4 years, 2 months ago (2016-10-10 20:24:47 UTC) #4
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-10 21:26:28 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/2
4 years, 2 months ago (2016-10-10 21:26:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-10 22:32:23 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/311883)
4 years, 2 months ago (2016-10-10 22:32:24 UTC) #8
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-11 22:21:28 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/30001
4 years, 2 months ago (2016-10-11 22:21:54 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-11 23:28:17 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 2 months ago (2016-10-11 23:28:18 UTC) #12
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-12 22:27:58 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/50001
4 years, 2 months ago (2016-10-12 22:28:31 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-12 23:21:17 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/313487)
4 years, 2 months ago (2016-10-12 23:21:18 UTC) #16
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-13 00:05:05 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/70001
4 years, 2 months ago (2016-10-13 00:05:24 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-13 00:13:45 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/85622)
4 years, 2 months ago (2016-10-13 00:13:46 UTC) #20
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-14 13:45:47 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/70001
4 years, 2 months ago (2016-10-14 13:46:04 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-14 14:50:23 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 2 months ago (2016-10-14 14:50:24 UTC) #24
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-14 16:10:28 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/90001
4 years, 2 months ago (2016-10-14 16:10:50 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-14 17:12:06 UTC) #27
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 2 months ago (2016-10-14 17:12:07 UTC) #28
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-02 17:02:33 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/110001
3 years, 11 months ago (2017-01-02 17:02:40 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-02 17:09:13 UTC) #31
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/14386) ios-simulator-xcode-clang on ...
3 years, 11 months ago (2017-01-02 17:09:14 UTC) #32
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-09 16:47:45 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/130001
3 years, 11 months ago (2017-01-09 16:48:14 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-09 16:56:52 UTC) #35
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/337391)
3 years, 11 months ago (2017-01-09 16:56:53 UTC) #36
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-10 10:08:58 UTC) #37
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/150001
3 years, 11 months ago (2017-01-10 10:09:06 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-10 10:15:27 UTC) #39
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/338276)
3 years, 11 months ago (2017-01-10 10:15:28 UTC) #40
gambard
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-10 16:18:26 UTC) #41
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410583002/170001
3 years, 11 months ago (2017-01-10 16:19:01 UTC) #42
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-10 16:26:44 UTC) #43
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 16:26:45 UTC) #44 
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698