Show Media Router toolbar icon ephemerally for MR dialogs

chrome/browser/media/router/test_helper.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/router/test_helper.h"
 
+#include "chrome/browser/media/router/media_router_factory.h"
 #include "chrome/browser/media/router/media_source.h"
 
 namespace media_router {
 
+void MockPresentationSessionSuccessCallback(

[mark a. foltz, 2016/10/17 18:57:39]

PresentationSessionSessionSuccessCallback is just a base::Callback with template
arguments.

https://cs.chromium.org/chromium/src/chrome/browser/media/router/create_prese...

It would seem better to bind a function in the unit test that verifies if the
callback is called, versus implementing a do-nothing callback.  Check other unit
tests for examples of this pattern.

[takumif, 2016/10/27 23:06:38]

Moving the functions to media_router_dialog_controller_impl_unittest.cc, and
making them mock functions.

+    const content::PresentationSessionInfo&,
+    const MediaRoute::Id&) {}
+void MockPresentationSessionErrorCallback(const content::PresentationError&) {}
+
 MockIssuesObserver::MockIssuesObserver(MediaRouter* router)
     : IssuesObserver(router) {}
 MockIssuesObserver::~MockIssuesObserver() {}
 
 MockMediaSinksObserver::MockMediaSinksObserver(MediaRouter* router,
                                                const MediaSource& source,
                                                const GURL& origin)
     : MediaSinksObserver(router, source, origin) {}
 MockMediaSinksObserver::~MockMediaSinksObserver() {
 }
 
 MockMediaRoutesObserver::MockMediaRoutesObserver(MediaRouter* router,
     const MediaSource::Id source_id)
     : MediaRoutesObserver(router, source_id) {
 }
 MockMediaRoutesObserver::~MockMediaRoutesObserver() {
 }
 
 MockPresentationConnectionStateChangedCallback::
     MockPresentationConnectionStateChangedCallback() = default;
 
 MockPresentationConnectionStateChangedCallback::
     ~MockPresentationConnectionStateChangedCallback() = default;
 
+MockMediaRouterActionController::MockMediaRouterActionController(
+    Profile* profile)
+    : MediaRouterActionController(
+          profile,
+          media_router::MediaRouterFactory::GetApiForBrowserContext(profile),
+          nullptr,
+          nullptr) {}
+MockMediaRouterActionController::~MockMediaRouterActionController() {}
+
+MockMediaRouterUIService::MockMediaRouterUIService(Profile* profile)
+    : media_router::MediaRouterUIService(profile),
+      action_controller_(
+          base::MakeUnique<MockMediaRouterActionController>(profile)) {}
+MockMediaRouterUIService::~MockMediaRouterUIService() {}
+
+MediaRouterActionController* MockMediaRouterUIService::action_controller()
+    const {
+  return action_controller_.get();
+}
+
 }  // namespace media_router