Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2410533002: Remove now-unused string_iterator symbols (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
Reviewers:
caitp
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove now-unused string_iterator symbols These were used by the JS implementation, but are now dead code. R=caitp@igalia.com BUG=v8:5388 Committed: https://crrev.com/c0550b4cf4ead242b74097d89d0a922cf121d792 Cr-Commit-Position: refs/heads/master@{#40140}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/heap-symbols.h View 1 chunk +0 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
adamk
4 years, 2 months ago (2016-10-10 18:49:12 UTC) #1
caitp
https://codereview.chromium.org/2410533002/diff/1/src/heap-symbols.h File src/heap-symbols.h (left): https://codereview.chromium.org/2410533002/diff/1/src/heap-symbols.h#oldcode221 src/heap-symbols.h:221: V(string_iterator_next_index_symbol) \ thanks, lgtm
4 years, 2 months ago (2016-10-10 19:13:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410533002/1
4 years, 2 months ago (2016-10-10 19:16:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 19:46:26 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 19:46:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0550b4cf4ead242b74097d89d0a922cf121d792
Cr-Commit-Position: refs/heads/master@{#40140}

Powered by Google App Engine
This is Rietveld 408576698