Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2410523002: [Tracing] Remove State Sampling Profiling (Closed)

Created:
4 years, 2 months ago by fmeawad
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Tracing] Remove State Sampling Profiling The state sampling was implemented in chrome, we had an interface for it V8 but it was not implemented yet. The chrome version version has been removed in https://codereview.chromium.org/2406703002/ Therefore following up with its removal in V8 as well. This CL can land independent of the Chromium related CL. R=primiano@chromium.org,alph@chromium.org Committed: https://crrev.com/610fe2892b2c61858e5f4c81563b6fa0056a8672 Cr-Commit-Position: refs/heads/master@{#40232}

Patch Set 1 #

Patch Set 2 : Remove it from TraceConfig as well #

Patch Set 3 : CL for v8 perf tryjob to run speedometer benchmark on linux platform(s) #

Patch Set 4 : CL for v8 perf tryjob to run speedometer benchmark on linux platform(s) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -89 lines) Patch
M include/libplatform/v8-tracing.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M src/d8.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M src/tracing/trace-event.h View 3 chunks +0 lines, -75 lines 0 comments Download
M test/cctest/libplatform/test-tracing.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
fmeawad
PTAL
4 years, 2 months ago (2016-10-10 18:57:55 UTC) #5
Primiano Tucci (use gerrit)
Ah you preceded me. I did an attempt of https://codereview.chromium.org/2402203002/ Funny enough, both of us ...
4 years, 2 months ago (2016-10-10 18:59:52 UTC) #6
fmeawad
On 2016/10/10 18:59:52, Primiano Tucci - slow til 10th wrote: > Ah you preceded me. ...
4 years, 2 months ago (2016-10-10 19:01:44 UTC) #7
fmeawad
CL for v8 perf tryjob to run speedometer benchmark on linux platform(s)
4 years, 2 months ago (2016-10-10 21:41:48 UTC) #14
fmeawad
CL for v8 perf tryjob to run speedometer benchmark on linux platform(s)
4 years, 2 months ago (2016-10-10 21:43:07 UTC) #15
fmeawad
+jochen since cbruni is OOO
4 years, 2 months ago (2016-10-11 16:34:08 UTC) #17
alph
lgtm
4 years, 2 months ago (2016-10-11 16:40:24 UTC) #18
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-12 09:13:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410523002/60001
4 years, 2 months ago (2016-10-12 15:06:36 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-12 15:34:44 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 15:34:59 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/610fe2892b2c61858e5f4c81563b6fa0056a8672
Cr-Commit-Position: refs/heads/master@{#40232}

Powered by Google App Engine
This is Rietveld 408576698