Issue 24105003: srand() + rand() -> SkRandom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24105003: srand() + rand() -> SkRandom (Closed)

Created:
7 years, 3 months ago by mtklein

Modified:
7 years, 3 months ago

Reviewers:
jvanverth1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

srand() + rand() -> SkRandom rand() makes these two GMs thread-unsafe. When run concurrently they can interfere with each other. Use SkRandom instead to guarantee independence. BUG=skia:1590 R=jvanverth@google.com Committed: https://code.google.com/p/skia/source/detail?r=11295

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -10 lines)			Patch
	M	gm/imageblur.cpp	View		2 chunks	+7 lines, -5 lines	0 comments	Download
	M	gm/imagemagnifier.cpp	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

7 years, 3 months ago (2013-09-16 18:19:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r11295 (presubmit successful).