Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2410453002: Handle private members in dart:mirrors (Closed)

Created:
4 years, 2 months ago by vsm
Modified:
4 years, 2 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More fixes #

Total comments: 6

Patch Set 3 : Address comments, merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -217 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 2 14 chunks +99 lines, -46 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 2 14 chunks +99 lines, -46 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 2 14 chunks +99 lines, -46 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 2 14 chunks +99 lines, -46 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 2 8 chunks +98 lines, -29 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
vsm
4 years, 2 months ago (2016-10-10 22:09:00 UTC) #2
Bob Nystrom
LGTM! https://codereview.chromium.org/2410453002/diff/20001/pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart File pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart (right): https://codereview.chromium.org/2410453002/diff/20001/pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart#newcode78 pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:78: Map m = JS('', '#.map(#)', _dart, data); The ...
4 years, 2 months ago (2016-10-10 22:43:58 UTC) #3
vsm
Committed patchset #3 (id:40001) manually as 2495f6a0606bd8ecab31ce2b45511aa2da8bd885 (presubmit successful).
4 years, 2 months ago (2016-10-10 22:55:29 UTC) #5
vsm
4 years, 2 months ago (2016-10-10 22:56:19 UTC) #6
Message was sent while issue was closed. 
thanks!  landing.

https://codereview.chromium.org/2410453002/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart (right):

https://codereview.chromium.org/2410453002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:78: Map m = JS('',
'#.map(#)', _dart, data);
On 2016/10/10 22:43:58, Bob Nystrom wrote:
> The first argument to JS is the return type, right? Should this be used here
> instead of typing the local?
> 
> Also, "m" -> "map", please. :)
> 
>
https://www.dartlang.org/guides/language/effective-dart/documentation#avoid-a...

Done.

https://codereview.chromium.org/2410453002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:221: var privateName =
str.substring(7, str.length - 1);
On 2016/10/10 22:43:58, Bob Nystrom wrote:
> You have the same logic above. Make a helper function?

Done.

https://codereview.chromium.org/2410453002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:390: // InstanceMirror
case, there are no dynamic helper to delegate to - we never
On 2016/10/10 22:43:58, Bob Nystrom wrote:
> "are" -> "is".

Done.

Powered by Google App Engine
This is Rietveld 408576698