Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2410413003: Decide ParseLazy vs ParseProgram based on is_toplevel (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Decide ParseLazy vs ParseProgram based on is_toplevel BUG=v8:5501 Committed: https://crrev.com/479e30c031cca5b45386f600a747f6757233b0c5 Cr-Commit-Position: refs/heads/master@{#40231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/parsing/parser.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-12 11:37:30 UTC) #2
marja
lgtm
4 years, 2 months ago (2016-10-12 12:10:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410413003/1
4 years, 2 months ago (2016-10-12 14:04:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410413003/1
4 years, 2 months ago (2016-10-12 14:56:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 15:22:14 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 15:22:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/479e30c031cca5b45386f600a747f6757233b0c5
Cr-Commit-Position: refs/heads/master@{#40231}

Powered by Google App Engine
This is Rietveld 408576698