Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2410373002: skpbench: add warmup run (Closed)

Created:
4 years, 2 months ago by csmartdalton
Modified:
4 years, 2 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skpbench: add warmup run Does actual work while waiting for hardware settings to kick in, rather than just sleeping. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2410373002 Committed: https://skia.googlesource.com/skia/+/5772eaa91d6a10d74959d7732513c5ab9c057e03

Patch Set 1 #

Patch Set 2 : skpbench: add warmup run #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -32 lines) Patch
M tools/skpbench/_hardware.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skpbench/_hardware_android.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skpbench/skpbench.cpp View 9 chunks +52 lines, -18 lines 0 comments Download
M tools/skpbench/skpbench.py View 1 5 chunks +30 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 2 months ago (2016-10-11 22:34:22 UTC) #3
bsalomon
lgtm
4 years, 2 months ago (2016-10-12 00:13:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410373002/20001
4 years, 2 months ago (2016-10-12 01:11:41 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 01:28:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5772eaa91d6a10d74959d7732513c5ab9c057e03

Powered by Google App Engine
This is Rietveld 408576698