Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: test/cctest/cctest.gyp

Issue 2410353005: Fix generate-bytecode-expectations to work in component builds (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/cctest.gyp
diff --git a/test/cctest/cctest.gyp b/test/cctest/cctest.gyp
index 0b015693020c62a9d9c5edfc3626fc3a645ea047..a251d6a5241a989f701c9d3f60c5c5522fb13c84 100644
--- a/test/cctest/cctest.gyp
+++ b/test/cctest/cctest.gyp
@@ -474,17 +474,10 @@
'target_name': 'generate-bytecode-expectations',
'type': 'executable',
'dependencies': [
+ '../../src/v8.gyp:v8',
+ '../../src/v8.gyp:v8_libbase',
'../../src/v8.gyp:v8_libplatform',
],
- 'conditions': [
- ['component=="shared_library"', {
- # Same as cctest, we need to depend on the underlying static target.
- 'dependencies': ['../../src/v8.gyp:v8_maybe_snapshot'],
- 'defines': [ 'BUILDING_V8_SHARED', ]
- }, {
- 'dependencies': ['../../src/v8.gyp:v8'],
- }],
- ],
'include_dirs+': [
'../..',
],
« no previous file with comments | « test/cctest/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698