Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2410353005: Fix generate-bytecode-expectations to work in component builds (Closed)

Created:
4 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 2 months ago
CC:
rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix generate-bytecode-expectations to work in component builds R=machenbach@chromium.org,jgruber@chromium.org,mythria@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe Committed: https://crrev.com/c592e454007e1e321f5d8ac4ca8238efdc611269 Cr-Commit-Position: refs/heads/master@{#40300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -33 lines) Patch
M src/interpreter/bytecode-array-iterator.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/interpreter/bytecode-operands.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/bytecode-register.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/ostreams.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/source-position-table.h View 2 chunks +2 lines, -1 line 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +2 lines, -10 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
jochen (gone - plz use gerrit)
ptal
4 years, 2 months ago (2016-10-14 07:23:02 UTC) #3
jgruber
lgtm
4 years, 2 months ago (2016-10-14 08:14:59 UTC) #10
Benedikt Meurer
LGTM (stampf)
4 years, 2 months ago (2016-10-14 08:44:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410353005/1
4 years, 2 months ago (2016-10-14 08:53:06 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 08:55:44 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 08:56:19 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c592e454007e1e321f5d8ac4ca8238efdc611269
Cr-Commit-Position: refs/heads/master@{#40300}

Powered by Google App Engine
This is Rietveld 408576698