Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2410353004: OBJECT_PRINT needs to have ICState2String() defined. (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

OBJECT_PRINT needs to have ICState2String() defined. R=ishell@chromium.org BUG= Committed: https://crrev.com/0bf492215c91c9b26b79bd35c7516e2a64ca5c21 Cr-Commit-Position: refs/heads/master@{#40270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -29 lines) Patch
M src/objects.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +36 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Igor, I ran across this small bug when debugging chromium. Thanks for the look! ...
4 years, 2 months ago (2016-10-13 12:28:23 UTC) #1
Igor Sheludko
lgtm
4 years, 2 months ago (2016-10-13 12:48:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410353004/1
4 years, 2 months ago (2016-10-13 13:21:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 14:06:08 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 14:06:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bf492215c91c9b26b79bd35c7516e2a64ca5c21
Cr-Commit-Position: refs/heads/master@{#40270}

Powered by Google App Engine
This is Rietveld 408576698