Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2410353002: Moving logic for System UI state changes into DesktopCanvas class (Closed)

Created:
4 years, 2 months ago by joedow
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Moving logic for System UI state changes into DesktopCanvas class Most of the logic for reacting to System UI changes was already in the DesktopCanvaqs class however there was one boolean check outside of that. Instead of adding yet another parameter to the DesktopCanvas handler method, I now pass the event parameters themselves. This will allow future changes to the logic to be made solely in the DesktopCanvas class. BUG=654565 Review-Url: https://codereview.chromium.org/2410613003 Cr-Commit-Position: refs/heads/master@{#424284} (cherry picked from commit 77a6c664de52f6a28910ab585a347ed0f4c2d899) Committed: https://chromium.googlesource.com/chromium/src/+/48c4493746716ffec1fae380abc80583b6fc2326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -40 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java View 1 chunk +25 lines, -28 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
joedow
4 years, 2 months ago (2016-10-11 22:36:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
48c4493746716ffec1fae380abc80583b6fc2326.

Powered by Google App Engine
This is Rietveld 408576698