Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2410333006: Implement ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(). (Closed)
Patch Set: add comment in sw_fetch_dispatcher.cc and split the media test change to 2427363004 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index d9d08837604403d2782db63eee0e53d20a7a2c5d..3fb185fad4391f78bae668c7f523d1862b9eaa57 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -1156,7 +1156,9 @@ void RenderProcessHostImpl::CreateMessageFilters() {
scoped_refptr<ServiceWorkerDispatcherHost> service_worker_filter =
new ServiceWorkerDispatcherHost(
- GetID(), message_port_message_filter_.get(), resource_context);
+ GetID(), message_port_message_filter_.get(), resource_context,
+ base::Bind(&RenderProcessHostImpl::CreateURLLoaderFactory,
+ weak_factory_.GetWeakPtr()));
service_worker_filter->Init(
storage_partition_impl_->GetServiceWorkerContext());
AddFilter(service_worker_filter.get());
@@ -3008,4 +3010,15 @@ void RenderProcessHostImpl::OnMojoError(int render_process_id,
bad_message::RPH_MOJO_PROCESS_ERROR);
}
+// static
+bool RenderProcessHostImpl::CreateURLLoaderFactory(
+ base::WeakPtr<RenderProcessHostImpl> weak_host,
+ mojo::InterfaceRequest<mojom::URLLoaderFactory> request) {
sadrul 2016/10/19 14:42:43 This doesn't need to be a static, right?
horo 2016/10/19 14:48:41 I want to return false if RenderProcessHostImpl wa
sadrul 2016/10/19 15:13:31 I think the return type can be void, and you can c
horo 2016/10/19 16:08:02 Ah, sounds good. Done.
+ if (!weak_host)
+ return false;
+ URLLoaderFactoryImpl::Create(weak_host->resource_message_filter_,
+ std::move(request));
+ return true;
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698