Implement ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload().

content/browser/service_worker/service_worker_fetch_dispatcher.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_FETCH_DISPATCHER_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_FETCH_DISPATCHER_H_
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "content/browser/service_worker/service_worker_metrics.h"
 #include "content/common/content_export.h"
 #include "content/common/service_worker/fetch_event_dispatcher.mojom.h"
 #include "content/common/service_worker/service_worker_status_code.h"
 #include "content/common/service_worker/service_worker_types.h"
 #include "content/public/common/resource_type.h"
+#include "mojo/public/cpp/bindings/interface_request.h"
 #include "net/log/net_log_with_source.h"
 
 namespace net {
 class URLRequest;
 }  // namespace net
 
 namespace content {
 
+namespace mojom {
+class URLLoaderFactory;
+}  // namespace mojom
+
 class ServiceWorkerVersion;
 
 // A helper class to dispatch fetch event to a service worker.
 class CONTENT_EXPORT ServiceWorkerFetchDispatcher {
  public:
-  typedef base::Callback<void(ServiceWorkerStatusCode,
-                              ServiceWorkerFetchEventResult,
-                              const ServiceWorkerResponse&,
-                              const scoped_refptr<ServiceWorkerVersion>&)>
-      FetchCallback;
+  using URLLoaderFactoryCallback =
+      base::Callback<bool(mojo::InterfaceRequest<mojom::URLLoaderFactory>)>;

[falken, 2016/10/19 05:11:28]

Can we move this declaration to service_worker_types.h so it doesn't need to be
copy/pasted in multiple classes?

It's also not obvious from the name what URLLoaderFactoryCallback does. Maybe
add a comment that this creates a URLLoaderFactory?

[horo, 2016/10/19 06:22:52]

Done.

+  using FetchCallback =
+      base::Callback<void(ServiceWorkerStatusCode,
+                          ServiceWorkerFetchEventResult,
+                          const ServiceWorkerResponse&,
+                          const scoped_refptr<ServiceWorkerVersion>&)>;
 
   ServiceWorkerFetchDispatcher(
       std::unique_ptr<ServiceWorkerFetchRequest> request,
       ServiceWorkerVersion* version,
       ResourceType resource_type,
       const net::NetLogWithSource& net_log,
       const base::Closure& prepare_callback,
       const FetchCallback& fetch_callback);
   ~ServiceWorkerFetchDispatcher();
 
   // If appropriate, starts the navigation preload request and creates
   // |preload_handle_|.
-  void MaybeStartNavigationPreload(net::URLRequest* original_request);
+  void MaybeStartNavigationPreload(
+      net::URLRequest* original_request,
+      const URLLoaderFactoryCallback& url_loader_factory_callback);
 
   // Dispatches a fetch event to the |version| given in ctor, and fires
   // |fetch_callback| (also given in ctor) when finishes. It runs
   // |prepare_callback| as an intermediate step once the version is activated
   // and running.
   void Run();
 
  private:
   class ResponseCallback;
 
@@ skipping 23 matching lines @@
   mojom::FetchEventPreloadHandlePtr preload_handle_;
 
   base::WeakPtrFactory<ServiceWorkerFetchDispatcher> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerFetchDispatcher);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_FETCH_DISPATCHER_H_