Create AXAction and AXActionData as a way to simplify accessibility actions

Create AXAction and AXActionData as a way to simplify accessibility actions

Previously we had a collection of 10 accessibility actions that were
implemented on every accessibility object - all of them implemented for
the web, and about half implemented for aura views and for the automation
extension API.

This resulted in a lot of boilerplate code because of the many layers of
indirection between the various parts of the codebase. Adding a new
accessibility action meant adding a new IPC and adding a new method to around
a dozen files just to plumb it through.

In comparison, we have dozens of accessibility events but we handle them all
with a single flexible data structure, so adding a new event doesn't require
so much plumbing.

This change streamlines accessibility actions too. There's
an enum AXAction with all of the possible accessibility actions, and a
serializable data structure AXActionData that encapsulates the parameters
needed by an accessibility action.

This cuts down on some duplicate code and reduces the amount of new code
that needs to be written to add support for a new accessibility action in
the future. For example, macOS has "increment" and "decrement" actions for
range controls that we ought to support, and there are some additional
arguments to setAccessibilityFocus that we're contemplating.

BUG=655272, 655273
TESTED=Manually triggered each of the supported accessibility actions from
    ChromeVox, and from at least one native screen reader.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/daa9dd2ccf9e285d7dd9b389f663f5122506f1f3
Cr-Commit-Position: refs/heads/master@{#425980}

[dmazzoni, 2016-10-12 20:30:41]

Description was changed from

==========
Create AXAction and AXActionData as a way to simplify accessibility actions

Previously we had a collection of 10 accessibility actions that were
implemented on every accessibility object - all of them implemented for
the web, and about half implemented for aura views and for the automation
extension API.

This resulted in a lot of boilerplate code because of the many layers of
indirection between the various parts of the codebase. Adding a new
accessibility action meant adding a new IPC and adding a new method to around
a dozen files just to plumb it through.

In comparison, we have dozens of accessibility events but we handle them all
with a single flexible data structure, so adding a new event doesn't require
so much plumbing.

This change streamlines accessibility actions too. There's
an enum AXAction with all of the possible accessibility actions, and a
serializable data structure AXActionData that encapsulates the parameters
needed by an accessibility action.

This cuts down on some duplicate code and reduces the amount of new code
that needs to be written to add support for a new accessibility action in
the future. For example, macOS has "increment" and "decrement" actions for
range controls that we ought to support, and there are some additional
arguments to setAccessibilityFocus that we're contemplating.

BUG=655272, 655273
TESTED=Manually triggered each of the supported accessibility actions from
    ChromeVox, and from at least one native screen reader.
==========

to

==========
Create AXAction and AXActionData as a way to simplify accessibility actions

Previously we had a collection of 10 accessibility actions that were
implemented on every accessibility object - all of them implemented for
the web, and about half implemented for aura views and for the automation
extension API.

This resulted in a lot of boilerplate code because of the many layers of
indirection between the various parts of the codebase. Adding a new
accessibility action meant adding a new IPC and adding a new method to around
a dozen files just to plumb it through.

In comparison, we have dozens of accessibility events but we handle them all
with a single flexible data structure, so adding a new event doesn't require
so much plumbing.

This change streamlines accessibility actions too. There's
an enum AXAction with all of the possible accessibility actions, and a
serializable data structure AXActionData that encapsulates the parameters
needed by an accessibility action.

This cuts down on some duplicate code and reduces the amount of new code
that needs to be written to add support for a new accessibility action in
the future. For example, macOS has "increment" and "decrement" actions for
range controls that we ought to support, and there are some additional
arguments to setAccessibilityFocus that we're contemplating.

BUG=655272, 655273
TESTED=Manually triggered each of the supported accessibility actions from
    ChromeVox, and from at least one native screen reader.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dmazzoni, 2016-10-12 20:30:44]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-10-12 20:31:21]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2016-10-12 20:31:22]

David, please take a first look, then I'll get owners.

[commit-bot: I haz the power, 2016-10-12 20:31:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 20:53:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 20:53:12]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dmazzoni, 2016-10-12 22:25:24]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 22:25:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 22:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 22:40:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-10-13 18:43:22]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 18:43:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 18:59:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 18:59:02]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[dmazzoni, 2016-10-13 19:42:39]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 19:42:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:55:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:55:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dmazzoni, 2016-10-13 20:22:47]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 20:23:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 20:42:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:42:04]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dmazzoni, 2016-10-13 20:56:29]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 20:56:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:10:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 21:10:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[David Tseng, 2016-10-13 22:15:14]

lgtm

https://codereview.chromium.org/2410333005/diff/100001/chrome/browser/ui/aura...
File chrome/browser/ui/aura/accessibility/automation_manager_aura.cc (right):

https://codereview.chromium.org/2410333005/diff/100001/chrome/browser/ui/aura...
chrome/browser/ui/aura/accessibility/automation_manager_aura.cc:117: // Not
implemented yet.
NOTREACHED

https://codereview.chromium.org/2410333005/diff/100001/chrome/browser/ui/aura...
chrome/browser/ui/aura/accessibility/automation_manager_aura.cc:121: break;
default, to get a compile time warning?

[dmazzoni, 2016-10-14 20:49:39]

https://codereview.chromium.org/2410333005/diff/100001/chrome/browser/ui/aura...
File chrome/browser/ui/aura/accessibility/automation_manager_aura.cc (right):

https://codereview.chromium.org/2410333005/diff/100001/chrome/browser/ui/aura...
chrome/browser/ui/aura/accessibility/automation_manager_aura.cc:117: // Not
implemented yet.
On 2016/10/13 22:15:14, David Tseng wrote:
> NOTREACHED

Done

https://codereview.chromium.org/2410333005/diff/100001/chrome/browser/ui/aura...
chrome/browser/ui/aura/accessibility/automation_manager_aura.cc:121: break;
On 2016/10/13 22:15:14, David Tseng wrote:
> default, to get a compile time warning?

I deliberately left out default so that if we
add a new enum we'll be forced to think about it
here

[dmazzoni, 2016-10-14 20:55:56]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 20:56:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 21:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 21:38:28]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[dmazzoni, 2016-10-17 05:05:36]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 05:05:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 07:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 07:19:23]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-10-17 17:06:19]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 17:06:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-10-17 17:08:36]

dmazzoni@chromium.org changed reviewers:
+ jam@chromium.org, tsepez@chromium.org

[dmazzoni, 2016-10-17 17:08:37]

+tsepez for accessibility_messages.h
+jam for content/public/browser/

[commit-bot: I haz the power, 2016-10-17 18:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 18:06:57]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-17 18:13:35]

messages LGTM

[jam, 2016-10-18 15:40:29]

lgtm

[dmazzoni, 2016-10-18 16:01:38]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-10-18 16:01:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2410333005/#ps160001
(title: "Simplify dependencies by putting the action enum inside AXActionData")

[commit-bot: I haz the power, 2016-10-18 16:02:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 16:07:26]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-10-18 16:09:00]

Description was changed from

==========
Create AXAction and AXActionData as a way to simplify accessibility actions

Previously we had a collection of 10 accessibility actions that were
implemented on every accessibility object - all of them implemented for
the web, and about half implemented for aura views and for the automation
extension API.

This resulted in a lot of boilerplate code because of the many layers of
indirection between the various parts of the codebase. Adding a new
accessibility action meant adding a new IPC and adding a new method to around
a dozen files just to plumb it through.

In comparison, we have dozens of accessibility events but we handle them all
with a single flexible data structure, so adding a new event doesn't require
so much plumbing.

This change streamlines accessibility actions too. There's
an enum AXAction with all of the possible accessibility actions, and a
serializable data structure AXActionData that encapsulates the parameters
needed by an accessibility action.

This cuts down on some duplicate code and reduces the amount of new code
that needs to be written to add support for a new accessibility action in
the future. For example, macOS has "increment" and "decrement" actions for
range controls that we ought to support, and there are some additional
arguments to setAccessibilityFocus that we're contemplating.

BUG=655272, 655273
TESTED=Manually triggered each of the supported accessibility actions from
    ChromeVox, and from at least one native screen reader.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Create AXAction and AXActionData as a way to simplify accessibility actions

Previously we had a collection of 10 accessibility actions that were
implemented on every accessibility object - all of them implemented for
the web, and about half implemented for aura views and for the automation
extension API.

This resulted in a lot of boilerplate code because of the many layers of
indirection between the various parts of the codebase. Adding a new
accessibility action meant adding a new IPC and adding a new method to around
a dozen files just to plumb it through.

In comparison, we have dozens of accessibility events but we handle them all
with a single flexible data structure, so adding a new event doesn't require
so much plumbing.

This change streamlines accessibility actions too. There's
an enum AXAction with all of the possible accessibility actions, and a
serializable data structure AXActionData that encapsulates the parameters
needed by an accessibility action.

This cuts down on some duplicate code and reduces the amount of new code
that needs to be written to add support for a new accessibility action in
the future. For example, macOS has "increment" and "decrement" actions for
range controls that we ought to support, and there are some additional
arguments to setAccessibilityFocus that we're contemplating.

BUG=655272, 655273
TESTED=Manually triggered each of the supported accessibility actions from
    ChromeVox, and from at least one native screen reader.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/daa9dd2ccf9e285d7dd9b389f663f5122506f1f3
Cr-Commit-Position: refs/heads/master@{#425980}
==========

[commit-bot: I haz the power, 2016-10-18 16:09:02]

Patchset 9 (id:??) landed as
https://crrev.com/daa9dd2ccf9e285d7dd9b389f663f5122506f1f3
Cr-Commit-Position: refs/heads/master@{#425980}

[Guido Urdaneta, 2016-10-18 16:20:14]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2430473003/ by guidou@chromium.org.

The reason for reverting is: Caused compile failure on Cast Android bot.

See
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Cast%20Android...

[779/836] CXX
obj/content/browser/browser/browser_accessibility_manager_android.o
FAILED: obj/content/browser/browser/browser_accessibility_manager_android.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/content/browser/browser/browser_accessibility_manager_android.o.d
-DENABLE_SCREEN_CAPTURE=1 -DAPPCACHE_USE_SIMPLE_CACHE
-DUSE_MINIKIN_HYPHENATION=1 -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS
-DENABLE_PLUGINS=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1
-DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1
-DENABLE_WEBRTC=1 -DDISABLE_NACL -DUSE_PROPRIETARY_CODECS -DCHROMIUM_BUILD
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=283753-1 -D_FILE_OFFSET_BITS=64
-DANDROID -DHAVE_SYS_UIO_H -DANDROID_NDK_VERSION=r12b -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D__GNU_SOURCE=1 -D__compiler_offsetof=__builtin_offsetof
-Dnan=__builtin_nan -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DCONTENT_IMPLEMENTATION
-DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_MOJO_MEDIA -DENABLE_MOJO_CDM
-DENABLE_MOJO_AUDIO_DECODER -DENABLE_MOJO_MEDIA_IN_GPU_PROCESS -DUSE_EGL
-DDISABLE_FFMPEG_VIDEO_DECODERS -DLEVELDB_PLATFORM_CHROMIUM=1
-DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS
-DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA
-DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD
-DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT=
-DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE
-DOPUS_FIXED_POINT -DMESA_EGL_NO_X11_HEADERS -DPOSIX_AVOID_MMAP
-DDISABLE_FTP_SUPPORT=1 -DENABLE_WEBSOCKETS -DFEATURE_ENABLE_SSL
-DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH
-DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD
-DWEBRTC_POSIX -DWEBRTC_LINUX -DWEBRTC_ANDROID -DXML_STATIC -DSSL_USE_OPENSSL
-DHAVE_OPENSSL_SSL_H -DFEATURE_ENABLE_SSL -DLOGGING=1 -DNO_MAIN_THREAD_WRAPPING
-I../.. -Igen -I../../third_party/khronos -I../../gpu
-I../../third_party/leveldatabase -I../../third_party/leveldatabase/src
-I../../third_party/leveldatabase/src/include -I../../skia/config
-I../../skia/ext -I../../third_party/skia/include/c
-I../../third_party/skia/include/config -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/images
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu
-I../../third_party/skia/src/sksl -I../../third_party/protobuf/src
-Igen/protoc_out -I../../third_party/protobuf/src -Igen/blink
-I../../third_party/icu/source/common -I../../third_party/icu/source/i18n
-I../../third_party/libwebm/source -Igen/media/base/android/media_jni_headers
-Igen/media/base/android/media_jni_headers/media
-I../../third_party/opus/src/include -Igen -I../../third_party/ced/src
-I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include
-Igen/v8/include -I../../third_party/boringssl/src/include -I../../v8/include
-Igen/v8/include -I../../third_party/mesa/src/include
-I../../third_party/angle/src/common/third_party/numerics -Igen/angle
-I../../third_party/libyuv/include -I../../third_party/re2/src
-I../../third_party/zlib -Igen/ui/resources -Igen/ui/resources
-I../../third_party/webrtc_overrides -I../../testing/gtest/include
-I../../third_party -I../../third_party/webrtc_overrides -I../../third_party
-I../../third_party/expat/files/lib
-Igen/content/public/android/content_jni_headers
-Igen/content/public/android/content_jni_headers/content -Igen/jar_jni/content
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables
-fPIC -pipe -fcolor-diagnostics -ffunction-sections -fno-short-enums
--target=arm-linux-androideabi -march=armv7-a -mfloat-abi=softfp -mthumb
-mtune=generic-armv7-a -mfpu=neon -Wall -Werror -Wextra
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template
-Wno-nonportable-include-path -Wno-address-of-packed-member -Os
-fno-omit-frame-pointer -gdwarf-3 -g1
--sysroot=../../third_party/android_tools/ndk/platforms/android-16/arch-arm
-fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion
-Wexit-time-destructors -Wno-unused-function -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wno-undefined-bool-conversion
-Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include
-isystem../../third_party/android_tools/ndk/sources/android/support/include
-fno-exceptions -c
../../content/browser/accessibility/browser_accessibility_manager_android.cc -o
obj/content/browser/browser/browser_accessibility_manager_android.o
../../content/browser/accessibility/browser_accessibility_manager_android.cc:702:34:
error: no member named 'AccessibilityShowContextMenu' in
'content::BrowserAccessibilityDelegate'
    node->manager()->delegate()->AccessibilityShowContextMenu(node->GetId());
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~  ^.

[findit-for-me, 2016-10-18 16:30:50]

FYI: Findit identified this CL at revision 425980 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[huangs, 2016-10-18 16:43:16]

The failed line

> 'content::BrowserAccessibilityDelegate'
>     node->manager()->delegate()->AccessibilityShowContextMenu(node->GetId());
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~  ^.

does not seem to appear in the CL??