Fix for scoring password autofill candidates:

components/password_manager/core/browser/password_form_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/run_loop.h"
@@ skipping 684 matching lines @@
   form_manager.ProvisionallySave(
       complete_form, PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
   // By now that form has been used once.
   complete_form.times_used = 1;
 
   // Check that PasswordStore receives an update request with the complete form.
   EXPECT_CALL(*mock_store(), UpdateLogin(complete_form));
   form_manager.Save();
 }
 
+TEST_F(PasswordFormManagerTest, TestScoringPublicSuffixMatch) {
+  base::MessageLoop message_loop;
+
+  TestPasswordManagerClient client(NULL);
+  MockPasswordManagerDriver driver;
+  EXPECT_CALL(driver, IsOffTheRecord()).WillRepeatedly(Return(false));
+  EXPECT_CALL(driver, AllowPasswordGenerationForForm(_));
+
+  TestPasswordManager password_manager(&client);
+  scoped_ptr<PasswordFormManager> manager(new PasswordFormManager(
+    &password_manager, &client, &driver, *observed_form(), false));
+
+  // Simulate having two matches for this form, one of which was from different
+  // signon realm, and latter had a different origin and action. Public suffix
+  // match should force higher score, so the second one should be preserved.

[Garrett Casto, 2014/04/24 22:35:29]

I think the ordering of the results doesn't match the ordering that you talk
about here (second has different signon_realm, first has different origin and
action). This last sentence also doesn't ready very smoothly. Could you say
something like "Signon realm is the most important, so the first is preserved".

+  std::vector<PasswordForm*> results;
+  results.push_back(CreateSavedMatch(false));
+  results.push_back(CreateSavedMatch(false));
+  results[0]->origin = GURL("http://accounts.google.com/a/ServiceLoginAuth2");
+  results[0]->action = GURL("http://accounts.google.com/a/ServiceLogin2");
+  results[1]->original_signon_realm = "http://accounts2.google.com";
+  SimulateFetchMatchingLoginsFromPasswordStore(manager.get());
+  SimulateResponseFromPasswordStore(manager.get(), results);
+  EXPECT_EQ(1u, password_manager.GetLatestBestMatches().size());
+  EXPECT_EQ("", password_manager.GetLatestBestMatches().begin()
+      ->second->original_signon_realm);
+}
+
 }  // namespace password_manager