chrome/test/data/frame_tree/anchor_targeting_remote_frame.html - Issue 2410303006: Avoiding going through RenderFrameProxy when targeting a *new* frame.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/frame_tree/anchor_targeting_remote_frame.html

Issue 2410303006: Avoiding going through RenderFrameProxy when targeting a *new* frame. (Closed)

Patch Set: s/!canIgnoreTargetFrame/shouldNavigateTargetFrame/g Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <script>

	5 function simulateClick(properties) {

	6 var evt = new MouseEvent("click", properties);

	7

	8 target = document.getElementById("test-anchor");

	9 return target.dispatchEvent(evt);

	10 }

	11 </script>

	12 </head>

	13 <body>

	14 This page helps testing shift-clicking or ctrl-clicking an anchor/link

	15 that normally (when clicked without any modifier keys) targets a remote,

	16 cross-site frame. See also https://crbug.com/647772.

	17 <hr>

	18 <a href="/cross-site/c.com/title1.html"

	19 target="cross-site-frame"

	20 id="test-anchor">Test link to click while holding shift key</a>
	alexmos 2016/10/19 23:48:30 nit: s/shift/ctrl/, since that's what the test doe nit: s/shift/ctrl/, since that's what the test does? Łukasz Anforowicz 2016/10/19 23:52:01 Done. Show quoted text On 2016/10/19 23:48:30, alexmos wrote: > nit: s/shift/ctrl/, since that's what the test does? Done.
	21 <hr>

	22 <iframe

	23 name="cross-site-frame"

	24 src="/cross-site/b.com/title1.html"></iframe>

	25 </body>

	26 </html>

OLD	NEW