Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Issue 2410293003: [runtime] Rename FieldTypeGroup to FieldOwnerGroup. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Rename FieldTypeGroup to FieldOwnerGroup. We want to extend the use of this code dependency, so the name does no longer reflect the purpose. R=ishell@chromium.org Committed: https://crrev.com/c6779297a11619e3c4fe1bd2955c6ca23f06f691 Cr-Commit-Position: refs/heads/master@{#40210}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/compilation-dependencies.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/access-info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-12 10:40:37 UTC) #1
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/2410293003/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/2410293003/diff/1/src/objects.h#newcode5842 src/objects.h:5842: // Group of code that ...
4 years, 2 months ago (2016-10-12 10:44:18 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/2410293003/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/2410293003/diff/1/src/objects.h#newcode5842 src/objects.h:5842: // Group of code that omit run-time type checks ...
4 years, 2 months ago (2016-10-12 10:45:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410293003/20001
4 years, 2 months ago (2016-10-12 10:45:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 11:11:06 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 11:11:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c6779297a11619e3c4fe1bd2955c6ca23f06f691
Cr-Commit-Position: refs/heads/master@{#40210}

Powered by Google App Engine
This is Rietveld 408576698