Chromium Code Reviews
DescriptionRemove MessageLoop::current() from stress_cache.cc.
Whenever possible, use ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current(). ThreadTaskRunnerHandle::Get() works within
TaskScheduler while MessageLoop::current() doesn't.
Good reasons to use MessageLoop::current():
- Add destruction, nesting or task observers.
- Run nested loops.
Bad reasons to use MessageLoop::current():
- Post tasks. Use ThreadTaskRunnerHandle::Get() instead.
- Watch a file descriptor. Use FileDescriptorWatcher instead.
- Verify that it is possible to post tasks to the current thread.
Use ThreadTaskRunnerHandle::IsSet() instead.
- Verify that code runs on a specific thread. Use
SingleThreadTaskRunner::BelongsToCurrentThread() instead.
BUG=650723
Committed: https://crrev.com/ee2d4541810dee5db617b97be02b5a48f55143f4
Cr-Commit-Position: refs/heads/master@{#425141}
Patch Set 1 #
Messages
Total messages: 12 (7 generated)
|
|||||||||||||||||||