Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 2410233002: android: Use gold in arm64 builds too. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 import("//build/toolchain/goma.gni") 9 import("//build/toolchain/goma.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 !is_clang && !is_win_fastlink && !is_syzyasan 71 !is_clang && !is_win_fastlink && !is_syzyasan
72 } 72 }
73 73
74 declare_args() { 74 declare_args() {
75 # Whether to use the gold linker from binutils instead of lld or bfd. 75 # Whether to use the gold linker from binutils instead of lld or bfd.
76 use_gold = !use_lld && !(is_chromecast && is_linux && 76 use_gold = !use_lld && !(is_chromecast && is_linux &&
77 (current_cpu == "arm" || current_cpu == "mipsel")) && 77 (current_cpu == "arm" || current_cpu == "mipsel")) &&
78 ((is_linux && (current_cpu == "x64" || current_cpu == "x86" || 78 ((is_linux && (current_cpu == "x64" || current_cpu == "x86" ||
79 current_cpu == "arm" || current_cpu == "mipsel")) || 79 current_cpu == "arm" || current_cpu == "mipsel")) ||
80 (is_android && (current_cpu == "x86" || current_cpu == "x64" || 80 (is_android && (current_cpu == "x86" || current_cpu == "x64" ||
81 current_cpu == "arm"))) 81 current_cpu == "arm" || current_cpu == "arm64")))
82 } 82 }
83 83
84 # If it wasn't manually set, set to an appropriate default. 84 # If it wasn't manually set, set to an appropriate default.
85 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level") 85 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level")
86 if (symbol_level == -1) { 86 if (symbol_level == -1) {
87 if (is_android && use_order_profiling) { 87 if (is_android && use_order_profiling) {
88 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which 88 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which
89 # causes the linker to produce an invalid ELF. http://crbug.com/574476 89 # causes the linker to produce an invalid ELF. http://crbug.com/574476
90 symbol_level = 0 90 symbol_level = 0
91 } else if (is_win && use_goma && !is_clang) { 91 } else if (is_win && use_goma && !is_clang) {
(...skipping 15 matching lines...) Expand all
107 symbol_level = 0 107 symbol_level = 0
108 } 108 }
109 } 109 }
110 110
111 # Assert that the configuration isn't going to hit https://crbug.com/648948. 111 # Assert that the configuration isn't going to hit https://crbug.com/648948.
112 assert(ignore_elf32_limitations || !is_android || android_64bit_target_cpu || 112 assert(ignore_elf32_limitations || !is_android || android_64bit_target_cpu ||
113 is_component_build || symbol_level < 2 || is_clang, 113 is_component_build || symbol_level < 2 || is_clang,
114 "Android 32-bit non-component, non-clang builds cannot have " + 114 "Android 32-bit non-component, non-clang builds cannot have " +
115 "symbol_level=2 due to 4GiB file size limit, see " + 115 "symbol_level=2 due to 4GiB file size limit, see " +
116 "https://crbug.com/648948") 116 "https://crbug.com/648948")
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698