Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 241023002: Make Heap::AllocateRaw*String private. (Closed)

Created:
6 years, 8 months ago by Michael Starzinger
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Make Heap::AllocateRaw*String private. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M src/heap.h View 3 chunks +10 lines, -15 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 8 months ago (2014-04-17 14:01:47 UTC) #1
Yang
On 2014/04/17 14:01:47, Michael Starzinger wrote: lgtm.
6 years, 8 months ago (2014-04-17 14:02:57 UTC) #2
Michael Starzinger
6 years, 8 months ago (2014-04-17 14:58:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20856 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698