Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2410203002: PPC/s390: [fullcodegen] Don't count CallIC calls as patching ICs. (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [fullcodegen] Don't count CallIC calls as patching ICs. Port 001926cdeca5fe1882cb017c102ffb8bfc42dd04 Original commit message: In fullcodegen we used to count CallICs as patching ICs, and thus the heuristics are currently off by the number of calls in a code object. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/73683ef8f7c4b53e98cf2b97e13a2d6bb165a53f Cr-Commit-Position: refs/heads/master@{#40182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 2 months ago (2016-10-11 15:37:14 UTC) #1
john.yan
lgtm
4 years, 2 months ago (2016-10-11 15:48:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410203002/1
4 years, 2 months ago (2016-10-11 16:21:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 16:46:41 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 16:47:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73683ef8f7c4b53e98cf2b97e13a2d6bb165a53f
Cr-Commit-Position: refs/heads/master@{#40182}

Powered by Google App Engine
This is Rietveld 408576698