Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2410193006: Tentative fix for scroll event related crashes on the NTP (Closed)

Created:
4 years, 2 months ago by Marc Treib
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Tentative fix for scroll event related crashes on the NTP A crash[1] seems to be caused by events attempting to get data from the NTP while it is not the current page anymore. This CL adds a check to ensure the page processing the events is the currently displayed NTP. [1]: https://crbug.com/649670#c17 BUG=649670 Review-Url: https://codereview.chromium.org/2400163002 Cr-Commit-Position: refs/heads/master@{#423858} (cherry picked from commit 83034cc5fb53f6d66f73f3a8afbfdd0d14b42943) Committed: https://chromium.googlesource.com/chromium/src/+/5d06125ffec380d152ac244963fc2b154ed109da

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 2 months ago (2016-10-12 16:10:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d06125ffec380d152ac244963fc2b154ed109da.

Powered by Google App Engine
This is Rietveld 408576698